Skip to content

Refactor PlatformIO build scripts #6887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

valeros
Copy link
Contributor

@valeros valeros commented Jun 20, 2022

This pull request includes the following two major improvements:

  • Refactored structure of the build scripts. Currently, the build scripts for each ESP32 family include a lot of duplicated code. Updating this code in four different places is tedious and error-prone. In this PR, the common code is moved to the generic platformio-build.py script.
  • Updated process of searching for a proper partition table and bootloader image. It now behaves similarly to the Arduino IDE by searching in the variant directory in the first place.

I believe this PR shouldn't affect the autogeneration process implemented in the esp32-arduino-lib-builder script as only the common parts of the code were moved.

@me-no-dev
Copy link
Member

merged! Will apply this to the lib-builder and see the result later :)

@valeros valeros deleted the platformio-updates branch June 24, 2022 14:32
@VojtechBartoska VojtechBartoska added the IDE: PlaformIO Issue relates to PlatformIO IDE label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDE: PlaformIO Issue relates to PlatformIO IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants