Skip to content

Improve support for hand-written asm source files #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

ivankravets
Copy link
Contributor

Improve support for hand-written asm source files and document flag scopes

@CLAassistant
Copy link

CLAassistant commented May 27, 2022

CLA assistant check
All committers have signed the CLA.

@me-no-dev
Copy link
Member

these parts of the files are automatically generated by the lib-builder. Values are extracted from IDF's build system.

@ivankravets
Copy link
Contributor Author

How about with ASFLAGS and ASPPFLAGS? There is a bug in the current scripts with "-x", "assembler-with-cpp" which is set for ASFLAGS instead of ASPPFLAGS.

@me-no-dev
Copy link
Member

This is the part of the script that generates your configs. Above it is how they are obtained. I suggest you look there for resolution :)

@ivankravets
Copy link
Contributor Author

Could you adapt my fixes for the ASM? I'm not so good in the Bash. I'll close this PR. Thanks.

@me-no-dev
Copy link
Member

will do my best :)

@VojtechBartoska VojtechBartoska added the IDE: PlaformIO Issue relates to PlatformIO IDE label May 30, 2022
@me-no-dev
Copy link
Member

@ivankravets will the change for "ASPPFLAGS" be enough? Can I just rename "ASFLAGS" to "ASPPFLAGS"?

@ivankravets
Copy link
Contributor Author

If you don't use bare ASM (without C preprocessor, small .s), then just rename ASFLAGS -> ASPPFLAGS.

The ASFLAGS are common for .s and .S, whereas ASPPFLAGS only for .S. The .s very often require machine-related flags. However, it seems they are not required for ESP toolchains.

@me-no-dev
Copy link
Member

Will be part of 2.0.4 :)

@VojtechBartoska VojtechBartoska added the Area: LIB Builder Depends on Lib Builder label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LIB Builder Depends on Lib Builder IDE: PlaformIO Issue relates to PlatformIO IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants