Allow BluetoothSerial::connect() with specified channel and more options #6380

ferbar · 2022-03-06T08:47:38Z

By completing this PR sufficiently, you help us to improve the quality of Release Notes

Checklist

Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
Please provide related links (eg. Issue, other Project, submodule PR..)
Please check Contributing guide

This entire section above can be deleted if all items are checked.

Summary

Improve options of BluetoothSerial::connect(), improve error handling

Impact

BTAddress constification, BTAdvertisedDevice;
Add: connect with channel, sec_mask (auth/no-auth), role options(master/slave)
Add: getChannels() - list remote SPP channels
Add: isClosed - connection aborted by remote side, no need to wait for a connection.
Add: setTimeout - set timeout for read() or peek()
Add: Example for discover, getChannels(), connect() with options, isClosed()

Existing code should not be affected.

Unit Test Results

0 files 0 suites 0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit f43f196.

♻️ This comment has been updated with latest results.

SuGlider · 2022-04-06T18:53:04Z

@ferbar - please check some errors when CI tries to compile it. Thanks.

https://github.com/espressif/arduino-esp32/runs/5856471430?check_suite_focus=true

SuGlider · 2022-04-06T19:18:05Z

libraries/BluetoothSerial/examples/DiscoverConnect/DiscoverConnect.ino

+#if !defined(CONFIG_BT_ENABLED) || !defined(CONFIG_BLUEDROID_ENABLED)
+#error Bluetooth is not enabled! Please run `make menuconfig` to and enable it
+#endif
+


Please add this test as well (it is in every SPP example in order to warn users that try to run it in any chip but ESP32).

#if !defined(CONFIG_BT_SPP_ENABLED)
#error Serial Bluetooth not available or not enabled. It is only available for the ESP32 chip.
#endif

SuGlider · 2022-04-06T19:20:10Z

@ferbar - Thanks for this PR. It improves SPP functionality and API.
I'll try it as well, but in general it looks good to me.
As soon as the CI issues are fixed, and I finish testing it, we shall merge it.

please add also `.skip.esp32s3` file to the examples folder. This shall solve the CI issue.

ferbar · 2022-04-08T06:06:25Z

@SuGlider may I ask you to start the CI. Thanks!

VojtechBartoska · 2022-04-08T08:16:48Z

@ferbar started :)

* LittleFs is working with C3 * Delete .skip.esp32c3 * Add support for extra flash images (espressif#6625) This PR adds support for uploading additional flash images (e.g. Adafruit Tiny UF2 bootloader) specified in board manifests. Additionally, the PR switches the PlatformIO CI script to the upstream version of the ESP32 dev-platform (basically reverts changes introduced in espressif#5387 as they are no longer required). * publish.yml: Remove a leftover parenthesis that was making the workflow (espressif#6620) Description of Change Remove a leftover parenthesis that was making the workflow that was making the workflow invalid. Tests scenarios Github Workflow. Related links https://github.com/espressif/arduino-esp32/actions/runs/2213167501 Signed-off-by: Abdelatif Guettouche <[email protected]> * Enable LittleFs sketches for C3 (espressif#6618) * LittleFs is working with C3 * Delete .skip.esp32c3 * Update LittleFS PlatformIO example (espressif#6617) * Added RainMaker support on Arduino IDE for ESP32-C3/S2/S3 (espressif#6598) * Added RainMaker support on Arduino IDE for ESP32-C3/S2/S3 Closes espressif#6573 Note related to the issue espressif#6435 * Touch change to init only selected GPIO. (espressif#6609) * Separated init for touch / channel called by touchRead() * compile error * Fixed touch_V2 + ISR * Allow BluetoothSerial::connect() with specified channel and more options (espressif#6380) * BTAddress const, add bool() * BTAdvertisedDevice: const functions * BluetoothSerial: add: getChannels, add isClosed, add read/peek timeout, add connect with channel# * BluetoothSerial: add sec_mask, role in ::connect * BluetoothSerial add discover and connect with channel number example * DiscoverConnect: add SPP_ENABLED check * DiscoverConnect: disable on esp32s3 * Fixes stream load memory leak in WifiSecureClient for SSL CACert, Certificate, and (espressif#6387) Private Key. Issue presented during any subsequent invocation of loadCACert, loadCertificate, and loadPrivateKey, respectively, after the first invocation. * Call i2c_set_timeout in i2cSetClock (espressif#6537) * Uniform behaviour of WiFiClientSecure and WiFiClient setTimeout() (espressif#6562) * Uniform timeout WiFiClient-WiFiClientSecure * Added missing prototype * Add socket check on setTimeout * enh(log) salvage TAG from ESP_IDF log-statements > (espressif#6567) by converting result log-rows from the 1st line to the 2nd (`NET` is the tag): ``` [ 73419][D][telelogger.cpp:915] telemetry(): state: 33C [ 73419][D][telelogger.cpp:915] telemetry(): [NET] state: 33C ``` Co-authored-by: Me No Dev <[email protected]> * add AirM2M_CORE_ESP32C3 board (espressif#6613) * add AirM2M_CORE_ESP32C3 board * Added Unexpected Maker Reflow Master Pro (UM RMP) board (espressif#6630) Fixed wrong SCK and MISO pins for TinyS2 * Tasmota changes (#24) * Update install-arduino-core-esp32.sh * Update CMakeLists.txt * Update Esp.cpp * Update Updater.cpp Co-authored-by: Valerii Koval <[email protected]> Co-authored-by: Abdelatif Guettouche <[email protected]> Co-authored-by: Pedro Minatel <[email protected]> Co-authored-by: Jan Procházka <[email protected]> Co-authored-by: Christian Ferbar <[email protected]> Co-authored-by: Billy <[email protected]> Co-authored-by: Paul <[email protected]> Co-authored-by: Gonzalo Brusco <[email protected]> Co-authored-by: Kostis Anagnostopoulos <[email protected]> Co-authored-by: Me No Dev <[email protected]> Co-authored-by: Darren Cheng <[email protected]> Co-authored-by: Unexpected Maker <[email protected]>

ferbar · 2022-04-27T20:12:00Z

Thanks!

cattledogGH · 2022-05-07T00:34:00Z

Nice new example.

SerialBT.setPin("1234"); // doesn't seem to change anything
SerialBT.enableSSP(); // doesn't seem to change anything

Unfortunately, even with these lines uncommented, this new example does not solve the issue of failure to connect to a device with a pin like an HC-05 with pin "1234".

#6061

espressif/esp-idf#8394

Is there any update on when the underlying issue in IDF will be resolved?

ferbar · 2022-05-07T08:01:29Z

@cattledogGH I'm sorry this PR is not related to esp32 => BT 2.0 device.

also see: #6193

ferbar added 5 commits March 3, 2022 22:41

BTAddress const, add bool()

7b44ebb

BTAdvertisedDevice: const functions

4ffb53e

BluetoothSerial: add: getChannels, add isClosed, add read/peek timeou…

12d5e72

…t, add connect with channel#

BluetoothSerial: add sec_mask, role in ::connect

364e8e0

BluetoothSerial add discover and connect with channel number example

57b269b

me-no-dev requested review from P-R-O-C-H-Y, PilnyTomas and SuGlider March 10, 2022 13:46

me-no-dev added Area: BT&Wifi BT & Wifi related issues Status: Test needed Issue needs testing labels Mar 10, 2022

PilnyTomas approved these changes Mar 16, 2022

View reviewed changes

ferbar mentioned this pull request Mar 20, 2022

BluetoothSerial / esp_bt_mem_release / memory consumption in arduino api #6451

Closed

1 task

Merge branch 'master' into pr_btserial

8baf733

SuGlider reviewed Apr 6, 2022

View reviewed changes

SuGlider self-assigned this Apr 6, 2022

ferbar added 2 commits April 7, 2022 19:25

DiscoverConnect: add SPP_ENABLED check

9d29684

DiscoverConnect: disable on esp32s3

cf5724c

Merge branch 'master' into pr_btserial

f43f196

me-no-dev merged commit b88a70a into espressif:master Apr 26, 2022

@@ @@ -50,6 +51,7 @@ class BluetoothSerial: public Stream @@
                       size_t write(const uint8_t *buffer, size_t size);
                       void flush();
                       void end(void);
+                      void setTimeout(int timeoutMS);

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow BluetoothSerial::connect() with specified channel and more options #6380

Allow BluetoothSerial::connect() with specified channel and more options #6380

ferbar commented Mar 6, 2022

CLAassistant commented Mar 6, 2022 •

edited

Loading

mrengineer7777 commented Mar 7, 2022

ferbar commented Mar 7, 2022 •

edited

Loading

mrengineer7777 commented Mar 7, 2022

PilnyTomas Mar 16, 2022

me-no-dev Mar 16, 2022

github-actions bot commented Apr 6, 2022 •

edited

Loading

SuGlider commented Apr 6, 2022

SuGlider Apr 6, 2022

SuGlider commented Apr 6, 2022 •

edited

Loading

ferbar commented Apr 8, 2022

VojtechBartoska commented Apr 8, 2022

ferbar commented Apr 27, 2022

cattledogGH commented May 7, 2022

ferbar commented May 7, 2022

Allow BluetoothSerial::connect() with specified channel and more options #6380

Allow BluetoothSerial::connect() with specified channel and more options #6380

Conversation

ferbar commented Mar 6, 2022

Checklist

Summary

Impact

Related links

CLAassistant commented Mar 6, 2022 • edited Loading

mrengineer7777 commented Mar 7, 2022

ferbar commented Mar 7, 2022 • edited Loading

mrengineer7777 commented Mar 7, 2022

PilnyTomas Mar 16, 2022

Choose a reason for hiding this comment

me-no-dev Mar 16, 2022

Choose a reason for hiding this comment

github-actions bot commented Apr 6, 2022 • edited Loading

Unit Test Results

SuGlider commented Apr 6, 2022

SuGlider Apr 6, 2022

Choose a reason for hiding this comment

SuGlider commented Apr 6, 2022 • edited Loading

please add also .skip.esp32s3 file to the examples folder. This shall solve the CI issue.

ferbar commented Apr 8, 2022

VojtechBartoska commented Apr 8, 2022

ferbar commented Apr 27, 2022

cattledogGH commented May 7, 2022

ferbar commented May 7, 2022

CLAassistant commented Mar 6, 2022 •

edited

Loading

ferbar commented Mar 7, 2022 •

edited

Loading

github-actions bot commented Apr 6, 2022 •

edited

Loading

SuGlider commented Apr 6, 2022 •

edited

Loading

please add also `.skip.esp32s3` file to the examples folder. This shall solve the CI issue.