Fix WiFiClientSecure memory leaks when the connection fails (certificate verification, handshake, etc.) #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thi may happen if read() gets called repeatedly (such as in HttpClient to parse response headers) and the connection is closed unexpectedly or the remote peer may have unexpected behavior that causes the underlying socket to report an error. In that case read() itself calls stop(), which invalidates the receive buffer object. Then when read() is called again without checking, such as inside readStringUntil(), the _rxBuffer is null and ESP32 crashes.
TLS data structures for CA certificate chain and client certifcate and private key were not deallocated if the function returns earlier due to some error. The fix makes sure to free this data in addition to the other cleanup already present in stop_ssl_socket(), which is called by the client when start_ssl_client() fails.
|
Closed because of wrong patch, repo was not in-sync with origin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #5781 and possibly others related to the same problem: the function
start_ssl_client()does not free memory allocated by mbed-tls library for data structures holding CA certificate, client certificate and private key, in case of early failures, but only when the connection is successful.The proposed fix adds some cleanup code to
stop_ssl_socket()so that WiFiSecureClient does not leak memory when it finally callsstop().