Skip to content

Update Ticker.cpp #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Ticker.cpp #5919

wants to merge 1 commit into from

Conversation

yaroshd81
Copy link

fix error when call method active(): undefined reference to Ticker::active()

fix error when call method active(): `undefined reference to Ticker::active()`
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bertmelis
Copy link
Contributor

I'm not sure about the behavioural specifics but I don't think this is right.

What should be the result when a one shot timer has already fires?
If your PR it would still be active but I'd say it is not active anymore.

@me-no-dev me-no-dev added the Resolution: Awaiting response Waiting for response of author label Dec 14, 2021
@everslick
Copy link
Contributor

Still it is the same implementation as on ESP8266:

bool Ticker::active() const                                                     
{                                                                               
    return _timer;                                                              
}    

@@ -56,3 +56,7 @@ void Ticker::detach() {
_timer = nullptr;
}
}

void Ticker::active() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type is wrong!!! Should be bool obviously.

@everslick
Copy link
Contributor

we could just return bool esp_timer_is_active(esp_timer_handle_t timer) and call it a day, though.

@me-no-dev
Copy link
Member

@everslick want to make a new PR with that? @yaroshd81 seems unresponsive?

@me-no-dev me-no-dev closed this Jan 18, 2022
@VojtechBartoska VojtechBartoska removed the Resolution: Awaiting response Waiting for response of author label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants