-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update Ticker.cpp #5919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ticker.cpp #5919
Conversation
fix error when call method active(): `undefined reference to Ticker::active()`
|
I'm not sure about the behavioural specifics but I don't think this is right. What should be the result when a one shot timer has already fires? |
Still it is the same implementation as on ESP8266:
|
@@ -56,3 +56,7 @@ void Ticker::detach() { | |||
_timer = nullptr; | |||
} | |||
} | |||
|
|||
void Ticker::active() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type is wrong!!! Should be bool
obviously.
we could just return |
@everslick want to make a new PR with that? @yaroshd81 seems unresponsive? |
fix error when call method active():
undefined reference to Ticker::active()