Skip to content

Fix boards.txt options for atmegazero_esp32s2 deneyapmini #5623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix boards.txt options for atmegazero_esp32s2 deneyapmini #5623

wants to merge 1 commit into from

Conversation

manchoz
Copy link

@manchoz manchoz commented Sep 2, 2021

Summary

Fixes #5618

Impact

None

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pedrominatel pedrominatel added the Type: Bug 🐛 All bugs label Sep 2, 2021
@vedantroy
Copy link

I'm blocked on this for a class I'm taking.
Is there a way to use this PR now (w/o it being merged in)?

@vedantroy vedantroy mentioned this pull request Sep 13, 2021
Closed
@eddieespinal
Copy link
Contributor

Thanks @manchoz for putting this PR. I had this fix locally and was waiting to put a PR until I fix the other issue I'm facing compiling with Arduino. I just opened a bug to see if someone can help with that. #5671

@eddieespinal
Copy link
Contributor

@manchoz I created a new PR to fix the issue, the changes you made won't work as I've tested it. Please see my PR and let me know if you have any questions.

#5673

@manchoz
Copy link
Author

manchoz commented Sep 15, 2021

@eddieespinal yes, please, go ahead with your PR!

@manchoz manchoz mentioned this pull request Sep 21, 2021
Merged
@me-no-dev
Copy link
Member

closing in favor of #5673

@me-no-dev me-no-dev closed this Oct 1, 2021
@manchoz manchoz deleted the mnx_fix_boards_txt branch April 1, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug 🐛 All bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Malformed board options in arduino-cli for atmegazero_esp32s2 and deneyapmini
6 participants
@manchoz @CLAassistant @vedantroy @eddieespinal @me-no-dev @pedrominatel