Skip to content

Update PlatformIO build script to handle spaces in env names #4791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2021
Merged

Update PlatformIO build script to handle spaces in env names #4791

merged 1 commit into from
Feb 15, 2021

Conversation

valeros
Copy link
Contributor

@valeros valeros commented Feb 10, 2021

This PR fixes a possible issue when a user specifies an environment with a whitespace character in its name, e.g.:

[env:esp wrover kit]
platform = espressif32
framework = arduino
board = esp-wrover-kit

platformio/platform-espressif32#483 depends on this fix.

cc @me-no-dev

@me-no-dev me-no-dev merged commit beedeea into espressif:idf-release/v4.2 Feb 15, 2021
@me-no-dev
Copy link
Member

thanks @valeros :)

ltungv added a commit to ltungv/arduino-esp32 that referenced this pull request Feb 21, 2021
@ltungv
Merge pull request #1 from espressif/idf-release/v4.2
b398a54 
Update PlatformIO build script to handle spaces in env name (espressif#4791)
me-no-dev pushed a commit that referenced this pull request Mar 31, 2021
@valeros @me-no-dev
Update PlatformIO build script to handle spaces in env name (#4791)
585398e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valeros @me-no-dev