Actually disable ssl when on windows (Cygwin) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espressif@4865ed0 says it disables on windows but does the opposite. python in cygwin says it can't find "ssl".
me-no-dev
reviewed
Nov 13, 2016
| @@ -71,13 +71,13 @@ def get_tool(tool): | |||
| local_path = dist_dir + archive_name | |||
| url = tool['url'] | |||
| #real_hash = tool['checksum'].split(':')[1] | |||
| if 'CYGWIN_NT' in sys_name: | |||
| if 'CYGWIN_NT' not in sys_name: | |||
There was a problem hiding this comment.
but this will disable SSL check on all other OSs. Maybe you need to install something to get it going?
There was a problem hiding this comment.
Ah I missunderstood what was going on here, I assumed the starting state before 4865ed0 was "ssl is enabled" but I see now you are correct it was disabled beforehand and that commit made it disabled only for windows. My mistake, sorry.
There was a problem hiding this comment.
Also as a datapoint while trying to determine how to get this script working for everyone. The script is broken on a clean install of "babun" (cygwin distro) on windows 10 but works if you follow the "not cygwin" path, i.e. with these changes.
brentru
pushed a commit
to adafruit/arduino-esp32
that referenced
this pull request
Oct 22, 2024
* Note about installing multiple libraries * "Hack" on how to install external libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4865ed0 says it disables on windows but does the opposite. python in cygwin says it can't find "ssl".