Skip to content

Update AzureIoT submodule to include the SNTP fix #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

photomoose
Copy link
Contributor

@photomoose photomoose commented Sep 3, 2020

This PR brings the AzureIoT library submodule up to date, so that the "Operating mode must not be set while SNTP client is running" SNTP bug fix is included in the Arduino ESP32 core.

See VSChina/ESP32_AzureIoT_Arduino#5 for a description of the issue (occurs on my Adafruit Feather ESP32 when a timeout occurs when sending messages to Azure IOT Hub).

The fix for the above issue was merged into master (see VSChina/ESP32_AzureIoT_Arduino#9).

Tested by explicitly fetching the platform package from my fork, as follows:

[env:featheresp32]
platform = espressif32
board = featheresp32
framework = arduino
platform_packages =
	framework-arduinoespressif32 @ https://github.com/photomoose/arduino-esp32.git

@lbernstone
Copy link
Contributor

It's ok to leave this for people looking for a fix, but AzureIoT will be removed from the next version, so the PR will never be merged.

@photomoose
Copy link
Contributor Author

@lbernstone What are the reasons for removing it? Also, once removed, is there an alternative?

@lbernstone
Copy link
Contributor

It is being removed as a submodule from this repository. The project is not going away. You will just need to download it separately like any other arduino library.

@me-no-dev me-no-dev merged commit 1f4491f into espressif:master Oct 1, 2020
@me-no-dev
Copy link
Member

nothing wrong to merge this since it's still a part of the repo :) but will be removed as submodule because it's hard to sync fixes and updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants