Skip to content

Reinit updater md5 related fields for cleanup #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CriPstian
Copy link
Contributor

MD5 cleanup on begin
Typos

MD5 cleanup on begin
Typos
@lbernstone
Copy link
Contributor

Can this not be part of _reset() so they are cleared on any abnormal result?

@CriPstian
Copy link
Contributor Author

I thought about it, but maybe it's better to have a clean start than cleaning up at the end.
There may be a case where the value is needed after a failure for a print maybe

@CriPstian
Copy link
Contributor Author

Fixes #4257

@me-no-dev me-no-dev merged commit 0957776 into espressif:master Oct 1, 2020
@CriPstian CriPstian deleted the bugfix/reinit-updater-md5-related-fields branch October 1, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants