Skip to content

Rename eep -> partitions.bin & hex -> bin #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

mjsir911
Copy link
Contributor

@mjsir911 mjsir911 commented Jul 7, 2020

This is in line with the arduino platform specification.

specifies that the file extension after recipe.objcopy is arbitrary. The AVR platform uses eep & hex, while the esp32 platform seems to have file extensions partition.bin & bin.

Note: I ran into this using the arduino platform specification to generate makefiles, this PR lets other software know about the dependency tree better.

Tested on Arduino 1.8.7

This is in line with the
[arduino platform specification](https://arduino.github.io/arduino-cli/platform-specification/#recipes-for-extraction-of-executable-files-and-other-binary-data)
specifying that the file extension after recipe.objcopy is arbitrary and
that the AVR platform uses `eep` & `hex`, while the esp32 platform seems
to have file extensions `partition.bin` & `bin`
@me-no-dev
Copy link
Member

Thanks @mjsir911 :) Any chance you rename partitions.bin to just partitions?

@mjsir911
Copy link
Contributor Author

@me-no-dev done

@me-no-dev
Copy link
Member

I wanted only recipe.objcopy.partitions.bin.pattern -> recipe.objcopy.partitions.pattern :)

@mjsir911
Copy link
Contributor Author

mjsir911 commented Oct 1, 2020

I wanted only recipe.objcopy.partitions.bin.pattern -> recipe.objcopy.partitions.pattern :)

This defeats the purpose of this PR, the file extension of the generated file is partition.bin. If the file extension portion of the recipe is incorrect then tools cannot infer the filename of the generated file.

@me-no-dev
Copy link
Member

tools cannot infer the filename of the generated file

I'm not sure I understand what you mean? what does the recipe name have to do with anything?

p.s. you do need to revert your last commit

@mjsir911
Copy link
Contributor Author

mjsir911 commented Oct 3, 2020

tools cannot infer the filename of the generated file

I'm not sure I understand what you mean? what does the recipe name have to do with anything?

As specified in the arduino platform specification:

recipe.objcopy.FILE_EXTENSION_1.pattern=[.....]
FILE_EXTENSION_x must be replaced with the extension of the extracted file

which is saying that the file extension between objcopy. & .pattern needs to be the file extension of the resulting file. This is useful for tools (like mine) to better infer the build steps needed & the intermediate files.

It looks like the Arduino app allows for file extensions with .s in it

@me-no-dev me-no-dev merged commit 831f0ac into espressif:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants