rewrite GetChipID.ino #4070
Merged
rewrite GetChipID.ino #4070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea when this pull request might get approved? Or even just get some feedback from someone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous GetChipID.ino example sketch was confusing and misleading -- and didn't provide an example that would actually be useful to a new user. Not only did it simply output the MAC address (which is already easily available) but it outputted it in reverse order.
The code has been rewritten so that it outputs the exact same thing as the ESP.getChipId() function on ESP8266 (a 32-bit integer matching the last 3 bytes of the MAC address). This is both a useful value and likely what a new user would expect given the name of this sketch.