Fixed incorrect usage of xEventGroupWaitBits

[wolph]

Related discussion in #3219

[IonicEV]

You may get note on bool vs. wait bitwise value. Originally, those changes resulted in logic errors by mistake. It may fail equal operator logic: (true == bit), as true most likely defined as 1, so 1 != 2, or 4 or 8 & etc. It would only work with bit = 1. It does not affect the existing code though.

[me-no-dev]

please bring back the braces and check if it's different than 0. While non-null value is technically TRUE, I would like the code to show that properly :)

[wolph]

I've added the != 0 and I've added parentheses (I assume you meant those instead of braces? Braces are { and })

[me-no-dev]

surely :D excuse my "English". braces, brackets, parentheses... it's a bit confusing

[wolph]

I know how it can be, English is not my native language either :)

[me-no-dev]

to me:

• ( braces
• { curly braces
• [ square braces / brackets
• parentheses sounds like it should be ' or "
• my own language sounds strange to me... go figure

[ItsShunya]

I'm having some trouble connecting my ESP32-WROOM-32 to any other device via bluetooth. I'm using the SerialtoSerialBTM example with the address and name modified only. The log I'm getting from the debug is the following:

[W][esp32-hal-psram.c:30] psramInit(): PSRAM init failed!
[I][BluetoothSerial.cpp:514] _init_bt(): device name set
[I][BluetoothSerial.cpp:227] esp_spp_cb(): ESP_SPP_INIT_EVT
[I][BluetoothSerial.cpp:120] btSetPin(): pin set
The device started in master mode, make sure remote BT device is on!
[I][BluetoothSerial.cpp:726] connect(): master : remoteAddress
[I][BluetoothSerial.cpp:292] esp_spp_cb(): ESP_SPP_DISCOVERY_COMP_EVT
Failed to connect. Make sure remote device is available and in range, then restart app.

I've seen that it sets the address right, and when doing the connect() function it returns false when doing waitForConnect(SCAN_TIMEOUT)
I believe that problem comes from the following line that was modified in this merge.
return (xEventGroupWaitBits(_spp_event_group, SPP_CONNECTED, pdFALSE, pdTRUE, xTicksToWait) & SPP_CONNECTED) != 0;

I've tried to connect to multiple deviced and it always returns false, any way to fix this?

Update: I've tried the same program using another ESP32-WROOM-32 that I had and the problem is the same

[atanisoft]

@Shunyavic open an issue for your issue rather than hijack a merged PR.

[wolph]

While this code fixes the bug that it was erroneously telling you it worked, it doesn't fix anything else.

I haven't been able to get the master mode working well either