Add an aditional (void *) arg to the RMT callback (much like Ticker() et.al.). #3345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xible handling of the callback (e.g. by passing a private struct or a class pointer). Same pattern as used by the Ticker() and many others. Example updated & new example with a trapoline added.
|
nice :) will hold it for a bit, just to make sure that 1.0.4 is all good before I change API |
|
If I understand the situation correctly, there is no way to use a classes member function as callback before this PR is merged. The example that is part of the PR illustrates this nicely by using a trampoline that passes Today this is possible with the ESP8266 Ticker lib, but not with the one for ESP32. Please merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an aditional (void *) arg to the RMT callback - to allow more flexible handling of the callback (e.g. by passing a private struct or a class pointer).
Same pattern as used by the Ticker() and many others. Example updated & new example with a trapoline added.
This lets you handle multiple RMT handlers with ease & without many global variables or tricks (as the current API does not provide access to the channel).