-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add ESP.getChipId() function to get ESP32's ChipID. #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@me-no-dev |
@wemos will you do what I asked? |
@me-no-dev |
@wemos did you miss my review? I would like you to rename the method to getEfuseMac() because the name is misleading :) I get that ESP8266 has this method and that the result could be interpreted as unique id of the chip, but still this is not the chip id that ESP8266 have. |
ok |
why did you close the pull request? |
I will make new |
@me-no-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
cores/esp32/Esp.h
Outdated
@@ -76,6 +76,8 @@ class EspClass | |||
bool flashWrite(uint32_t offset, uint32_t *data, size_t size); | |||
bool flashRead(uint32_t offset, uint32_t *data, size_t size); | |||
|
|||
uint64_t getChipId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like you to rename the method to getEfuseMac() because the name is misleading :) I get that ESP8266 has this method and that the result could be interpreted as unique id of the chip, but still this is not the chip id that ESP8266 have.
@me-no-dev
Add ESP.getChipId() function to get ESP32's ChipID.