Skip to content

Add ESP.getChipId() function to get ESP32's ChipID. #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2017
Merged

Add ESP.getChipId() function to get ESP32's ChipID. #322

merged 2 commits into from
May 5, 2017

Conversation

wemos
Copy link
Contributor

@wemos wemos commented Apr 21, 2017

@me-no-dev
Add ESP.getChipId() function to get ESP32's ChipID.

@wemos
Copy link
Contributor Author

wemos commented Apr 21, 2017

@me-no-dev
This is new pull request, could it be merge?

@me-no-dev
Copy link
Member

@wemos will you do what I asked?

@wemos
Copy link
Contributor Author

wemos commented Apr 28, 2017

@me-no-dev
yes, just add getChipId() without board update.

@me-no-dev
Copy link
Member

@wemos did you miss my review?

I would like you to rename the method to getEfuseMac() because the name is misleading :) I get that ESP8266 has this method and that the result could be interpreted as unique id of the chip, but still this is not the chip id that ESP8266 have.

@wemos
Copy link
Contributor Author

wemos commented Apr 28, 2017

ok

@wemos wemos closed this Apr 28, 2017
@me-no-dev
Copy link
Member

why did you close the pull request?

@wemos
Copy link
Contributor Author

wemos commented Apr 28, 2017

I will make new

@wemos wemos reopened this May 2, 2017
@wemos
Copy link
Contributor Author

wemos commented May 2, 2017

@me-no-dev
I change getChipId() to getEfuseMac().

Copy link
Member

@me-no-dev me-no-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@@ -76,6 +76,8 @@ class EspClass
bool flashWrite(uint32_t offset, uint32_t *data, size_t size);
bool flashRead(uint32_t offset, uint32_t *data, size_t size);

uint64_t getChipId();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like you to rename the method to getEfuseMac() because the name is misleading :) I get that ESP8266 has this method and that the result could be interpreted as unique id of the chip, but still this is not the chip id that ESP8266 have.

@me-no-dev me-no-dev merged commit a38ffe5 into espressif:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants