Pull in ESP8266 String::replace() fixes, others #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in bugfixes from the ESP8266 repo for problems in the SSO implementation of replace(). See the following patches for full details: esp8266/Arduino@54240d2#diff-8d9e71e16d437343017df828f0528f63 esp8266/Arduino@78a1a66#diff-8d9e71e16d437343017df828f0528f63 esp8266/Arduino@4e93584#diff-8d9e71e16d437343017df828f0528f63 Fixes espressif#3140
|
Thanks for taking the time @earlephilhower :) |
everslick
added a commit
to everslick/Arduino-ESP32-1.0.0
that referenced
this pull request
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in bugfixes from the ESP8266 repo for problems in the SSO
implementation of replace(). See the following patches for full
details:
esp8266/Arduino@54240d2#diff-8d9e71e16d437343017df828f0528f63
esp8266/Arduino@78a1a66#diff-8d9e71e16d437343017df828f0528f63
esp8266/Arduino@4e93584#diff-8d9e71e16d437343017df828f0528f63
Fixes #3140