feature(BluetoothSerial): add pinCode function #2765

xiongyumail · 2019-05-10T04:19:07Z

Hi，

This change enables Bluetooth Serial to use password pairing.
libbt.a requires you to recompile the build library to support simple pairing.
kconfig: // SSP (Secure Simple Pairing ) disable

#
# Bluetooth
#
CONFIG_BT_ENABLED=y

#
# Bluetooth controller
#
CONFIG_BTDM_CONTROLLER_MODE_BLE_ONLY=
CONFIG_BTDM_CONTROLLER_MODE_BR_EDR_ONLY=
CONFIG_BTDM_CONTROLLER_MODE_BTDM=y
CONFIG_BTDM_CONTROLLER_BLE_MAX_CONN=3
CONFIG_BTDM_CONTROLLER_BR_EDR_MAX_ACL_CONN=2
CONFIG_BTDM_CONTROLLER_BR_EDR_MAX_SYNC_CONN=0
CONFIG_BTDM_CONTROLLER_BLE_MAX_CONN_EFF=3
CONFIG_BTDM_CONTROLLER_BR_EDR_MAX_ACL_CONN_EFF=2
CONFIG_BTDM_CONTROLLER_BR_EDR_MAX_SYNC_CONN_EFF=0
CONFIG_BTDM_CONTROLLER_PINNED_TO_CORE_0=y
CONFIG_BTDM_CONTROLLER_PINNED_TO_CORE_1=
CONFIG_BTDM_CONTROLLER_PINNED_TO_CORE=0
CONFIG_BTDM_CONTROLLER_HCI_MODE_VHCI=y
CONFIG_BTDM_CONTROLLER_HCI_MODE_UART_H4=

#
# MODEM SLEEP Options
#
CONFIG_BTDM_CONTROLLER_MODEM_SLEEP=y
CONFIG_BTDM_MODEM_SLEEP_MODE_ORIG=y
CONFIG_BTDM_MODEM_SLEEP_MODE_EVED=
CONFIG_BTDM_LPCLK_SEL_MAIN_XTAL=y
CONFIG_BLE_SCAN_DUPLICATE=y
CONFIG_SCAN_DUPLICATE_BY_DEVICE_ADDR=y
CONFIG_SCAN_DUPLICATE_BY_ADV_DATA=
CONFIG_SCAN_DUPLICATE_BY_ADV_DATA_AND_DEVICE_ADDR=
CONFIG_SCAN_DUPLICATE_TYPE=0
CONFIG_DUPLICATE_SCAN_CACHE_SIZE=20
CONFIG_BLE_MESH_SCAN_DUPLICATE_EN=
CONFIG_BLUEDROID_ENABLED=y
CONFIG_BLUEDROID_PINNED_TO_CORE_0=y
CONFIG_BLUEDROID_PINNED_TO_CORE_1=
CONFIG_BLUEDROID_PINNED_TO_CORE=0
CONFIG_BTC_TASK_STACK_SIZE=8192
CONFIG_BTU_TASK_STACK_SIZE=4096
CONFIG_BLUEDROID_MEM_DEBUG=
CONFIG_CLASSIC_BT_ENABLED=y
CONFIG_A2DP_ENABLE=y
CONFIG_A2DP_SINK_TASK_STACK_SIZE=2048
CONFIG_A2DP_SOURCE_TASK_STACK_SIZE=2048
CONFIG_BT_SPP_ENABLED=y
CONFIG_HFP_ENABLE=y
CONFIG_HFP_CLIENT_ENABLE=y
CONFIG_HFP_AUDIO_DATA_PATH_PCM=y
CONFIG_HFP_AUDIO_DATA_PATH_HCI=
CONFIG_BT_SSP_ENABLED=
CONFIG_GATTS_ENABLE=y
CONFIG_GATTS_SEND_SERVICE_CHANGE_MANUAL=
CONFIG_GATTS_SEND_SERVICE_CHANGE_AUTO=y
CONFIG_GATTS_SEND_SERVICE_CHANGE_MODE=0
CONFIG_GATTC_ENABLE=y
CONFIG_GATTC_CACHE_NVS_FLASH=
CONFIG_BLE_SMP_ENABLE=y
CONFIG_BT_STACK_NO_LOG=y
CONFIG_BT_ACL_CONNECTIONS=4
CONFIG_BT_ALLOCATION_FROM_SPIRAM_FIRST=y
CONFIG_BT_BLE_DYNAMIC_ENV_MEMORY=y
CONFIG_BLE_HOST_QUEUE_CONGESTION_CHECK=
CONFIG_SMP_ENABLE=y
CONFIG_BT_RESERVE_DRAM=0xdb5c

chegewara · 2019-05-10T10:05:26Z

espressif/esp-idf#2774

me-no-dev · 2019-05-11T08:37:41Z

libraries/BluetoothSerial/src/BluetoothSerial.cpp

+        esp_bt_gap_set_pin(pin_type, 4, pin_code);
+        return true;
+    }
+    else


is the limit 4 chars?

#define ESP_BT_PIN_CODE_LEN 16 /*!< Max pin code length */ typedef uint8_t esp_bt_pin_code_t[ESP_BT_PIN_CODE_LEN]; /*!< Pin Code (upto 128 bits) MSB is 0 */

What is the reason for the limitaton?

@me-no-dev
Sorry for the late reply, I will modify the code, rebase and submit again.

me-no-dev · 2019-05-14T14:43:41Z

@xiongyumail will you address my question?

luc-github · 2019-05-21T05:02:16Z

Hi @me-no-dev do you plan to add a select menu in ide to choose which bt lib need to be used (with or without pairing)? Or pairing enabled lib will become the new default and only choice ?
I ask here because pair enabled lib is necessary for this PR

me-no-dev · 2019-06-05T11:31:26Z

Hi Luc :) I need to check this out. I really do not like to provide two libs and an IDE option, because that option will then need to be propagated to all other boards. And they are quite a few now :D

luc-github · 2019-06-05T11:40:48Z

Hi, I have no issue to have pair enabled lib as default ^_^. I am just curious and want to anticipated big change.
Thank you for your great work :)

me-no-dev · 2019-07-09T16:14:03Z

this option does not exist on the 3.2 branch... i'll leave this here in case it pops out

IonicEV · 2019-09-16T18:54:55Z

latest example_spp_initiator_demo.c shows how to provide default pin codes for 16 and 4 length when challenged in Master mode. I would upload bigger work to allow Pins, SSP and most important Master mode connection in BluetoothSerial[.h|.cpp]. Maybe a better option is to wait a little bit. As this small change would be incorporated in upcoming changes in https://github.com/IonicEV/arduino-esp32/tree/master/libraries/BluetoothSerial/src , although it looks like the progress is very slow with pull requests. There is another issue with when you call this method. You really want to set pin code before you started to accept connections in case of slave, but you can not because of this code would only work after BT stack is initialized with begin(), the default pin_code is not really the answer as you blocking others who are not using any pins.

luc-github · 2019-09-16T22:00:13Z

@me-no-dev I saw 4.0 idf is released, does it will be integrated in next coming update ? Is this will allow pin integration?
Not pushing, just collecting informations ^_^

atanisoft · 2019-09-16T23:55:57Z

@luc-github IDF v4 is only a beta and has breaking changes to v3.x. it will be a while before it is integrated.

IonicEV · 2019-09-16T23:58:12Z

I just pushed the initial code changes (20190916 - initial: support for Master mode, Pin and SSP) to the: https://github.com/IonicEV/arduino-esp32/tree/master/libraries/BluetoothSerial/src
See: examples/SerialToSerialBTM for example app

luc-github · 2019-09-17T00:15:59Z

@atanisoft thank you. So future update to be able to have bt pairing should be more the 3.3 right ?
@IonicEV your code still need to have to rebuild libbt.a., right ?

atanisoft · 2019-09-17T00:18:26Z

So future update to be able to have bt pairing should be more the 3.3 right ?

If that functionality is in IDF v3.3 yes, if not no...

IonicEV · 2019-09-17T00:29:40Z

I took the sources from Heltec-esp8266 which just a copy of this repo it seems. I did not need to recompile/rebuild anything. It is possible you are referring to slave mode pin handling (when it is your ESP32) that request remove master to provide the pin for security. For Master mode - pins worked out of the box without any changes (preset or when challenged for a pin by remote), the discussion about pins are dated Nov 30, 2018 on other forums, so it is being around for quite some time.

IonicEV · 2019-09-17T00:40:24Z

Not sure why Master mode did not receive any attention. ESP32 is way better gear vs. ESP8266 + HC05 "dongle", but by some irony nobody bothered to "show the way" with Master mode, despite the fact all the support was there. I think Master mode would push ESP32 over the top. I saw many folks are struggling with this all over the forums, pretty sure many just gave up on ESP32 BT Master option.

Skysurfer-14 · 2020-01-22T16:46:11Z

With which ESP-IDF version this solution will work? I've made this changes at my ESP-IDF V3.3 installation and had no success with PIN. There are no compiling errors, but still no PIN on pairing.

Gcopper22 · 2021-03-09T09:22:12Z

hello is there any option to use static pin for classic bluetooth pairing?I'm using eps32-arduinio core 1.0.5.The disable ssp is working only in 1.0.1 version.Thanks in advance

Gcopper22 · 2021-04-01T07:53:21Z

Hello, a lot of people also me, we are trying to find an option to set static PIN on Bluetooth classic serial connection when pairing. A way to input custom PIN not the default 123456.An old way was created for 1.0.1 version adding a custom libbt.a file that was disabling ssp as far as i know .We want to be able to have this option on newer versions. I'll appreciate anyone who really want to help

ingsoc · 2021-04-16T10:53:05Z

Bump

CLAassistant · 2021-04-28T17:02:34Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

muellerryan · 2021-05-19T20:28:12Z

Bump... Still looking for the option to set a custom pin code. It would save a lot of headaches!

ingsoc · 2021-05-19T21:30:48Z

Agreed. Still not got a simple solution.

…

On Wed, 19 May 2021, 21:28 muellerryan, ***@***.***> wrote: Bump... Still looking for the option to set a custom pin code. It would save a lot of headaches! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2765 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFNDZYDWFA7X3KP5SJ7MK3TOQNO5ANCNFSM4HL7XQAQ> .

Gcopper22 · 2021-08-01T19:36:58Z

Any news?,Fixed PIN for Classic BT on 1.0.6 version? Can someone compile libbt.a library with the proper settings to make it finaly worked????

PilnyTomas · 2023-07-31T08:19:24Z

Closing this PR because it is outdated - suggested functionality was implemented in different PR and is already merged.
One thing is however a red flag for this PR - turning off a feature in sdkconfig which would cause issues for people using the Secure Simple Pairing (SSP)

me-no-dev reviewed May 11, 2019

View reviewed changes

xiongyumail force-pushed the master branch from 33a11ec to 815157e Compare May 18, 2019 23:02

xiongyumail mentioned this pull request May 20, 2019

BluetoothSerial Status && API discussion for passkey/PIN #2320

Closed

feature(BluetoothSerial): add pinCode function

03f38a9

xiongyumail force-pushed the master branch from 815157e to 03f38a9 Compare June 15, 2019 17:11

Sagar-SQT approved these changes Feb 28, 2022

View reviewed changes

PilnyTomas closed this Jul 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(BluetoothSerial): add pinCode function #2765

feature(BluetoothSerial): add pinCode function #2765

xiongyumail commented May 10, 2019

chegewara commented May 10, 2019

me-no-dev May 11, 2019

me-no-dev May 11, 2019

xiongyumail May 15, 2019

me-no-dev commented May 14, 2019

luc-github commented May 21, 2019 •

edited

Loading

me-no-dev commented Jun 5, 2019

luc-github commented Jun 5, 2019

me-no-dev commented Jul 9, 2019

IonicEV commented Sep 16, 2019 •

edited

Loading

luc-github commented Sep 16, 2019

atanisoft commented Sep 16, 2019

IonicEV commented Sep 16, 2019 •

edited

Loading

luc-github commented Sep 17, 2019

atanisoft commented Sep 17, 2019

IonicEV commented Sep 17, 2019 •

edited

Loading

IonicEV commented Sep 17, 2019 •

edited

Loading

Skysurfer-14 commented Jan 22, 2020

Gcopper22 commented Mar 9, 2021

Gcopper22 commented Apr 1, 2021

ingsoc commented Apr 16, 2021

CLAassistant commented Apr 28, 2021

muellerryan commented May 19, 2021

ingsoc commented May 19, 2021 via email

Gcopper22 commented Aug 1, 2021

PilnyTomas commented Jul 31, 2023

feature(BluetoothSerial): add pinCode function #2765

feature(BluetoothSerial): add pinCode function #2765

Conversation

xiongyumail commented May 10, 2019

chegewara commented May 10, 2019

me-no-dev May 11, 2019

Choose a reason for hiding this comment

me-no-dev May 11, 2019

Choose a reason for hiding this comment

xiongyumail May 15, 2019

Choose a reason for hiding this comment

me-no-dev commented May 14, 2019

luc-github commented May 21, 2019 • edited Loading

me-no-dev commented Jun 5, 2019

luc-github commented Jun 5, 2019

me-no-dev commented Jul 9, 2019

IonicEV commented Sep 16, 2019 • edited Loading

luc-github commented Sep 16, 2019

atanisoft commented Sep 16, 2019

IonicEV commented Sep 16, 2019 • edited Loading

luc-github commented Sep 17, 2019

atanisoft commented Sep 17, 2019

IonicEV commented Sep 17, 2019 • edited Loading

IonicEV commented Sep 17, 2019 • edited Loading

Skysurfer-14 commented Jan 22, 2020

Gcopper22 commented Mar 9, 2021

Gcopper22 commented Apr 1, 2021

ingsoc commented Apr 16, 2021

CLAassistant commented Apr 28, 2021

muellerryan commented May 19, 2021

ingsoc commented May 19, 2021 via email

Gcopper22 commented Aug 1, 2021

PilnyTomas commented Jul 31, 2023

luc-github commented May 21, 2019 •

edited

Loading

IonicEV commented Sep 16, 2019 •

edited

Loading

IonicEV commented Sep 16, 2019 •

edited

Loading

IonicEV commented Sep 17, 2019 •

edited

Loading

IonicEV commented Sep 17, 2019 •

edited

Loading