Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Sign up

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

espressif / arduino-esp32 Public

Notifications You must be signed in to change notification settings
Fork 7.6k
Star 14.7k

Code
Issues 97
Pull requests 16
Discussions
Actions
Projects 2
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

Alternative Improve _uploadReadByte #2656

Merged

me-no-dev merged 12 commits intoespressif:masterespressif/arduino-esp32:masterfrom

vicatcu:alternative_improve_uploadReadByteCopy head branch name to clipboard

Apr 12, 2019

Conversation Commits12 (12)Checks Files changed

Commits

Commits on Apr 11, 2019

add opportunity for more than one retry to _uploadReadByte
vicatcu
committed
an alternative timeout-based method to making _uploadReadByte more resilient
vicatcu
committed
move timing variables in the correct scope
vicatcu
committed
implement and use client.getTimeout instead of hard-coded timeout in _uploadReadByte
vicatcu
committed
add missing return
vicatcu
committed
some refactoring to address respecting the timeout in a potentially deadlocked connection
vicatcu
committed
fix spelling in comment
vicatcu
committed
address review comments; move impl to cpp file for getTimeout, and remove local variable for currentMillis
vicatcu
committed
remove redundant cast
vicatcu
committed
need to check for timeout outside the inner while as well
vicatcu
committed

Commits on Apr 12, 2019

update WebUpdate example to print something in unexpected callback condition
vicatcu
committed
update log_e messages per review comments
vicatcu
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.