Skip to content

Fixed missing null terminator in EEPROM.readString() #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

kfitzgerald
Copy link
Contributor

Greetings,

This patch corrects an issue with EEPROM.readString(address, value, maxLen) not terminating the read string. The resulting symptoms can be garbage characters when used.

A similar issue, #1608, corrected the overload function EEPROM.readString(address), but did not address this function.

Additionally, this patch should close #1252.

Thanks,
-Kevin

@me-no-dev
Copy link
Member

arghh :) please rebase :) EEPROM files have moved slightly

@me-no-dev me-no-dev merged commit 89d6b89 into espressif:master Feb 14, 2019
@me-no-dev
Copy link
Member

Thanks!

@kfitzgerald
Copy link
Contributor Author

My pleasure! Thanks @me-no-dev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EEPROMClass readString Bug
2 participants