[Updater.cpp] Increasing stream timeout to avoid read timeout during OTA flash write #1886
Conversation
If using nginx webserver to feed the OTA stream with the binary, i'm getting reproducely _error #6 (stream read timeout) on a ESP32 Pycom LoPy with CPU revision 0. This error does not occur with some other ESP32 boards with same setup and server, don't know why. But i could fix the issue with the LoPy following a hint for ESP 8266 Update.cpp, found in this issue: esp8266/Arduino#1157 This PR is a quick&dirty fix. Problem should be further analysed and then solved at the root cause.
cyberman54
changed the title
|
I am not in favor of this PR. It would be better to use setTimeout on the Stream before you pass it into ::writeStream, outside of UpdateClass. This PR would always set the timeout to 10,000 ms without any possibility to change it. |
|
@Jeroen88 is right. I close this. |
|
I reopen this, because i did not find a working solution to set the timeout for the stream of class WifiClient before calling |
|
Closing this again, since the problem should be solved with pending PR #1979 |
|
Tested this "fix". Doesn't help. Still getting "ERROR[6]: Stream Read Timeout". Even up'ped the timeout to 60 seconds with no change. This issue is more prevalent on larger bins. BTW. This fix seems to help on local networks but if you're trying to update over the internet you'll still experience the same issue. |
If using a nginx webserver to feed a https OTA write flash stream with ~1,5MB binary data, i'm getting reproducely _error #6 (stream read timeout) on a ESP32 Pycom LoPy with CPU revision 0.
I was able to stable fix this by applying a patch to
Updater.cpp, following a hint for ESP 8266 Update.cpp, found at the end of this issue:esp8266/Arduino#1157
This PR is a quick&dirty fix. Problem should be further analysed and then solved at the root cause. Eventually this is a TCP related issue.