-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add BananaPi-BIT Development Board Support #1810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
#ifndef Pins_Arduino_h | ||
#define Pins_Arduino_h | ||
|
||
#include <stdint.h> | ||
|
||
#define EXTERNAL_NUM_INTERRUPTS 16 | ||
#define NUM_DIGITAL_PINS 40 | ||
#define NUM_ANALOG_INPUTS 16 | ||
|
||
#define analogInputToDigitalPin(p) (((p) < 20) ? (esp32_adc2gpio[(p)]) : -1) | ||
#define digitalPinToInterrupt(p) (((p) < 40) ? (p) : -1) | ||
#define digitalPinHasPWM(p) (p < 34) | ||
|
||
static const uint8_t BUZZER = 25; | ||
|
||
static const uint8_t BUTTON_A = 35; | ||
static const uint8_t BUTTON_B = 27; | ||
|
||
static const uint8_t RGB_LED = 4; | ||
static const uint8_t RGB_LED_POWER = 2; | ||
|
||
static const uint8_t LIGHT_SENSOR1 = 36; | ||
static const uint8_t LIGHT_SENSOR2 = 39; | ||
|
||
static const uint8_t TEMPERATURE_SENSOR = 34; | ||
|
||
static const uint8_t MPU9250_AD0 = 0; | ||
|
||
static const uint8_t TX = 1; | ||
static const uint8_t RX = 3; | ||
|
||
static const uint8_t SDA = 21; | ||
static const uint8_t SCL = 22; | ||
|
||
static const uint8_t SS = 5; | ||
static const uint8_t MOSI = 23; | ||
static const uint8_t MISO = 19; | ||
static const uint8_t SCK = 23; | ||
|
||
static const uint8_t P0 = 25; | ||
static const uint8_t P1 = 32; | ||
static const uint8_t P2 = 33; | ||
static const uint8_t P3 = 13; | ||
static const uint8_t P4 = 15; | ||
static const uint8_t P5 = 35; | ||
static const uint8_t P6 = 12; | ||
static const uint8_t P7 = 14; | ||
static const uint8_t P8 = 16; | ||
static const uint8_t P9 = 17; | ||
static const uint8_t P10 = 26; | ||
static const uint8_t P11 = 27; | ||
static const uint8_t P12 = 2; | ||
static const uint8_t P13 = 18; | ||
static const uint8_t P14 = 19; | ||
static const uint8_t P15 = 23; | ||
static const uint8_t P16 = 5; | ||
static const uint8_t P19 = 22; | ||
static const uint8_t P20 = 21; | ||
|
||
static const uint8_t DAC1 = 26; | ||
static const uint8_t DAC2 = 25; | ||
|
||
#endif /* Pins_Arduino_h */ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This define is used to convert from A[n] to gpio pin. Since you are choosing not to define analog input pins should you change both
NUM_ANALOG_INPUTS
andanalogInputtoDigitalPin()
to reflect this choice?Chuck.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the definition here can be retained, because we not only have to consider the primary users, but also the people with certain Arduino and ESP32 programming development foundations, they can not use our prepared P(n) in their own code , from the line definition A (n) such a pin, and, our board does not give up the ADC function.