-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add component CMakeLists.txt file for use with CMake-based build system #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@projectgus Using file-globbing is not recommended as per the CMake documentation. https://cmake.org/cmake/help/latest/command/file.html
|
@PerMalmberg That's right. However, within the IDF build system we do some tricks to make globbing more viable: That said, I have forgotten to use any of those tricks here - thanks for the reminder. Tomorrow I'll amend this PR to either use |
@projectgus Ah, yes that does make a difference. 👍 |
@projectgus ping me please when you are ready :) |
3600ab5
to
c11d36b
Compare
@PerMalmberg Redone with individual file names, as I realised there's no guarantee that arduino-esp32 will be a git repo in all cases. Thanks again for pointing that out. @me-no-dev PTAL. Will send a follow-up PR once we have support in IDF for overriding component names, but this should work for now. |
8ccd6ce
to
dbd707a
Compare
@me-no-dev Now with Travis checks to make sure the source file list is up to date. |
@projectgus please remove the script calling line from travis.yml because it will cause merge conflicts with the update branch that I am working on. We have moved scripting out of yml and I can add the line manually to the appropriate script :) thanks! |
Includes verification script (for Travis) that CMakeLists.txt contents match repo & submodule source files
dbd707a
to
0b0a756
Compare
…em (espressif#1508) Includes verification script (for Travis) that CMakeLists.txt contents match repo & submodule source files
ESP-IDF has a new CMake-based build system currently in preview release.
More details here
This PR adds a CMakeLists.txt file so arduino-esp32 component can be used with CMake-based IDF projects.
The one unusual restriction here is that the directory containing the component must be named
arduino-esp32
. Will fix this restriction before the CMake branch is made the default branch in ESP-IDF.