Selectable (from menu) partitions for m5stack #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with minimal SPIFFS partition size and OTA support for bigger apps
domints
reviewed
May 4, 2018
| m5stack-core-esp32.menu.PartitionScheme.no_ota.upload.maximum_size=2097152 | ||
| m5stack-core-esp32.menu.PartitionScheme.min_spiffs=Minimal SPIFFS (Large APPS with OTA) | ||
| m5stack-core-esp32.menu.PartitionScheme.min_spiffs.build.partitions=min_spiffs | ||
| m5stack-core-esp32.menu.PartitionScheme.min_spiffs.upload.maximum_size=1966080 |
There was a problem hiding this comment.
Also I think it's important to consider if your board may contain 2MB flash version of ESP32. If so, it would be good to add definition for minimal partition scheme.
I didn't add one to LOLIN32, as I think all of lolins come with 4MB flash.
There was a problem hiding this comment.
Currently, the original m5stack flash size also has only 4M,
but of course we have to remember about this possibility
Curclamas
pushed a commit
to Curclamas/arduino-esp32
that referenced
this pull request
Aug 21, 2018
* Additional partition scheme min_spiffs with minimal SPIFFS partition size and OTA support for bigger apps * Selectable (from menu) partitions for m5stack addition for m5stack (as is prepared for lolin32 board: espressif#1379) discourse here: espressif#1378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addition for m5stack (as is prepared for lolin32 board: #1379)
discussion here: #1378