Skip to content

Add Schedule and Functional/Scheduled Ticker #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hreintke
Copy link
Contributor

@hreintke hreintke commented Apr 22, 2018

Identical implementation as in ESP8266

@me-no-dev
Copy link
Member

How about this to get written in more ESP32 and RTOS style? Use a thread (start it on first call of schedule) instead of attaching always to the loop ;)

@hreintke
Copy link
Contributor Author

@me-no-dev
I have no problem doing it that way but then the functionality of the ESP32 & ESP8266 is fundamental different.
1/ the one-to-one loop/scheduled rhythm is lost
2/ as the scheduled functions would run in a separate thread, all needs to be thread safe

BTW, there is additional activity in the ESP8266 esp8266/Arduino#4609

Just let me know which way you want to go and I will provide a proposal.

@me-no-dev
Copy link
Member

I understand, but this is a dual-core chip which runs an actual OS, so let's make it run as it should. ESP8266 runs NonOS like most other MCUs.

@hreintke
Copy link
Contributor Author

@me-no-dev See PR #1516

@fabianoriccardi
Copy link

no hope about this PR? It would be great porting some old esp8266 program without messing up with different "API"

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@me-no-dev me-no-dev closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants