Add SYSTEM_EVENT_WIFI_READY call back + WiFiMode fixes
#1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lows you to hook in, as the sdk does not generate this event for you. As it stands the SDK does not appear to set `WIFI_MODE_NULL` correctly. if the wifi is initialised and set to `WIFI_MODE_NULL` it actually defaults to AP mode. This fix keeps `WIFI_MODE_NULL` within the ESP class if the wifi has not been init yet, and works in my testing. albeit a one sided conversation. espressif#1306
|
this PR helps me. tnx! |
|
Fix working here too; thanks. |
|
+1 fixed, please merge |
|
@sticilface can you please adjust this to be inline with the latest code? we added a parameter to the low level functions in order to enable proper persistency |
|
pinging dr. @sticilface ! :) |
|
@me-no-dev Sorry was busy last week. That should take care of it :) |
|
Thanks @sticilface :) |
|
Hi, Without this fix, I experiencing that WiFi.scanComplete() will return WIFI_SCAN_RUNNING forewer. |
Curclamas
pushed a commit
to Curclamas/arduino-esp32
that referenced
this pull request
Aug 21, 2018
) * Add `SYSTEM_EVENT_WIFI_READY` call back once wifi service is init. allows you to hook in, as the sdk does not generate this event for you. As it stands the SDK does not appear to set `WIFI_MODE_NULL` correctly. if the wifi is initialised and set to `WIFI_MODE_NULL` it actually defaults to AP mode. This fix keeps `WIFI_MODE_NULL` within the ESP class if the wifi has not been init yet, and works in my testing. albeit a one sided conversation. espressif#1306 * make changes compatible with new _persistent behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SYSTEM_EVENT_WIFI_READYcall back: allows you to hook in, as the sdk does not generate this event for you for some reason.As it stands the SDK does not appear to set
WIFI_MODE_NULLcorrectly. if the wifi is initialised and set toWIFI_MODE_NULLit actually defaults to AP mode. This fix keepsWIFI_MODE_NULLwithin the ESP class if the wifi has not been init yet, and works in my testing. albeit a one sided conversation.#1306