Skip to content

Fixed M5Stack build.board name #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Fixed M5Stack build.board name #1187

merged 1 commit into from
Mar 9, 2018

Conversation

m5stack
Copy link
Contributor

@m5stack m5stack commented Mar 6, 2018

No description provided.

@me-no-dev me-no-dev merged commit e9ee0ab into espressif:master Mar 9, 2018
Curclamas pushed a commit to Curclamas/arduino-esp32 that referenced this pull request Aug 21, 2018
@BrunDog
Copy link

BrunDog commented Aug 24, 2019

Despite this, it doesn't seem the pre-processor definition works correctly:

#ifdef M5Stack_Core_ESP32

is ignored on Arduino IDE with current ESP32 1.0.2. Any tips?

@atanisoft
Copy link
Collaborator

@BrunDog #ifdef ARUDINO_M5Stack_Core_ESP32 is the correct reference for it. all of the defines are prefixed with ARDUINO_.

@BrunDog
Copy link

BrunDog commented Aug 24, 2019

Wow I'm dumb... yes, forgot this. Trees/forest thingy. Thanks! BTW you have ARDUINO spelled incorrectly.

@atanisoft
Copy link
Collaborator

BTW you have ARDUINO spelled incorrectly.

fingers move faster than brain :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants