Updated to download mkspiffs 0.2.2 #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it will be necessary to update the SHA-256 hashes of checksum and filesize too, otherwise, the get.py will detect it as corrupt file |
|
It looks like the sha256 hash checking is commented out, and seems to work properly right now. However, in case that changes in the future, it certainly makes sense to update. When I get back this evening I'll put those together and push an update. |
|
I just updated the hashes and file sizes. It also turns out that the windows filename changed. I only tested the linux64 version. I also uncommented the hash checking, and it appears to work correctly. Not sure why it is currently commented out, so I didn't commit that change. |
|
Thanks! |
Curclamas
pushed a commit
to Curclamas/arduino-esp32
that referenced
this pull request
Aug 21, 2018
* Updated to download mkspiffs 0.2.2 * Updated to have proper hashes and sizes. Also updated to new windows file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the package template (used by tools/get.py) to download the new mkspiffs tool. This is in reference to #1022, and is necessary because of a change implemented in Dec 2017. Currently, the mkspiffs that is installed by get.py does not work with arduino-esp32, causing problems for https://github.com/me-no-dev/arduino-esp32fs-plugin.