-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(zigbee): Add method to set/get/report analog output #11431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the Zigbee library to support analog output functionality by adding new APIs and updating related examples.
- Introduces setAnalogOutput, getAnalogOutput, and reportAnalogOutput methods.
- Updates the attribute change callback signature and keywords.
- Adjusts example configurations and usage to target Zigbee coordinator/router devices.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
libraries/Zigbee/src/ep/ZigbeeAnalog.h | Added new analog output methods and modified callback signature. |
libraries/Zigbee/src/ep/ZigbeeAnalog.cpp | Implemented new functions for setting and reporting analog output. |
libraries/Zigbee/keywords.txt | Updated keywords in line with new API. |
libraries/Zigbee/examples/Zigbee_Analog_Input_Output/ci.json | Adjusted configuration for router mode. |
libraries/Zigbee/examples/Zigbee_Analog_Input_Output/Zigbee_Analog_Input_Output.ino | Updated mode check and added a call to setAnalogOutputResolution. |
libraries/Zigbee/examples/Zigbee_Analog_Input_Output/Zigbee_Analog_Input_Output.ino
Show resolved
Hide resolved
Test Results 76 files 76 suites 12m 48s ⏱️ Results for commit 9068d88. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
This pull request introduces updates to the Zigbee library, focusing on enhancing support for analog output functionality.
New methods added:
Tests scenarios
Tested with ESP32-C6 and the
Zigbee_Analog_Input_Output
example connecting to the HomeAssistant.Related links