-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(rmt): fixes example to run correctly within IDF 5.x #11292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Description of Change
This example crashes when running with the ESP32 because it doesn't support
SOC_RMT_SUPPORT_TX_LOOP_AUTO_STOP
feature. All other SoC were running the example correctly.The timming was also incorrect becuase it was sending one RMT Symbol less.
This PR fixes the example to run with no crashes for all the SoC supported by Arduino Core 3.2.x+
It also fixes the blink timming as verified by a logic analizer.
Tests scenarios
Tested using the example with ESP32, S2, S3, C3 and C6.
Related links
Closes #11281