-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(uart): sets correct ESP32/S2 clock source for the example #11286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Do you think this could be adapted as a test case in our UART CI test ? |
Description of Change
Rx Timeout example was not working correctly using ESP32 and ESP32-S2 due to default selection of REF_TICK as UART Clock Source. REF_TICK limits RX Timeout to 1.
This PR adds the necessary call to
HardwareSerial::setClockSource()
in order to make it work properly.Tests scenarios
Tested using the example code of this PR.
ESP32 | ESP32-S2 | ESP32-C3 | ESP32-C6 | ESP32-S3 | ESP32-H2
Expect output (see the time it takes to read 10 bytes):
Related links
None