-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix compile: api change from i2c_ll_slave_init(i2c->dev) to i2c_ll_enable_arbitration(i2c->dev, true) #11270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello Jason2866, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 0801e1f. |
I think a new check is needed for IDF 5.5, instead of removing the other ones. The core itself still supports 5.3-5.5 |
@@ -363,11 +359,7 @@ esp_err_t i2cSlaveInit(uint8_t num, int sda, int scl, uint16_t slaveID, uint32_t | |||
|
|||
i2c_ll_disable_intr_mask(i2c->dev, I2C_LL_INTR_MASK); | |||
i2c_ll_clear_intr_mask(i2c->dev, I2C_LL_INTR_MASK); | |||
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 4, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change should be reverted
@@ -337,12 +337,8 @@ esp_err_t i2cSlaveInit(uint8_t num, int sda, int scl, uint16_t slaveID, uint32_t | |||
} | |||
#endif // !defined(CONFIG_IDF_TARGET_ESP32P4) | |||
|
|||
i2c_ll_slave_init(i2c->dev); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 5, 0)
i2c_ll_enable_arbitration(i2c->dev, true);
i2c_ll_enable_fifo_mode(i2c->dev, true);
#else
i2c_ll_slave_init(i2c->dev);
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 4, 0)
i2c_ll_enable_fifo_mode(i2c->dev, true);
#else
i2c_ll_slave_set_fifo_mode(i2c->dev, true);
#endif
#endif
Also please target |
closing in favour of #11271 |
in actual IDF branch master. remove deprecated not needed code.
fix for https://github.com/espressif/esp32-arduino-lib-builder/actions/runs/14554194455/job/40828960172
@me-no-dev