-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix(SDMMC): Remove need for BOARD_HAS_SDMMC for esp32 #10713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SDMMC): Remove need for BOARD_HAS_SDMMC for esp32 #10713
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 61 files 61 suites 5m 33s ⏱️ Results for commit 7c95911. ♻️ This comment has been updated with latest results. |
Description of Change
This PR removed unnecessary check for define
BOARD_HAS_SDMMC
, which is causing that SDMMC can't be used if a board variant don't have this defined. No other SoC is affected by this PR.Tests scenarios
Tested with SDMMC example on ESP32-Wrover-kit
Related links
Close #10709