Skip to content

BOOT_PIN constant for all ESP32 SoC - Arduino v3.1.x (includes ESP32-P4) #10701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Dec 9, 2024

Description of Change

Adds a const uint8_t BOOT_PIN for each ESP32 SoC that can be used in the Arduino Sketch.

Tests scenarios

CI and testing sketch:

void setup() {
  pinMode(BOOT_PIN, INPUT_PULLUP);
  Serial.begin(115200);
}

void loop() {
  if (digitalRead(BOOT_PIN) == LOW) {
    Serial.println("Boot Button is pressed.");
  } else {
    Serial.println("Boot Button is released.");
  }
  delay(3000);
}

Related links

None

@SuGlider SuGlider added this to the 3.1.0 milestone Dec 9, 2024
@SuGlider SuGlider self-assigned this Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Warnings
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 492fc7c

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 492fc7c.

@SuGlider SuGlider closed this Dec 9, 2024
@SuGlider SuGlider deleted the boot_pin_3.1.x branch December 9, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant