-
Notifications
You must be signed in to change notification settings - Fork 7.6k
ESP32-P4 UART pins setup, begin, detach, loopback function FIX #10517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit dc1a9f3. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Description of Change
In order to make ESP32-P4 UART loopback to work, the UART peripheral bit enables internal UART loop back.
It shall be turned off when the Serial port ends or when the RX or TX pins are detached.
This PR also deals with ESP32-P4 that has 5 UART ports.
There is definition for UART0 and UART1 pins.
Other UART shall have its pins setup in
begin()
.This PR checks if the pins have been set and issues an error message in case no pins RX/TX are defined.
Tests scenarios
ESP32-P4 only
Related links
None