Skip to content

Update boards.txt #10249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update boards.txt #10249

wants to merge 1 commit into from

Conversation

microbotsio
Copy link
Contributor

Update of codecell board parameters

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.

Description of Change

Please describe your proposed Pull Request and it's impact.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

@microbotsio
Update boards.txt
064b5a2 
Update of codecell board parameters
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello microbotsio, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 064b5a2

@lucasssvaz lucasssvaz requested a review from P-R-O-C-H-Y August 27, 2024 15:54
@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Aug 27, 2024 •
edited
Loading

@microbotsio Can you please provide better description and title?
Also if you are changing variant to esp32c3, it will not use your pins_arduino.h file of your variant.
Are you sure the PR is correct?

@P-R-O-C-H-Y P-R-O-C-H-Y added the Resolution: Awaiting response Waiting for response of author label Aug 27, 2024
me-no-dev
me-no-dev reviewed Aug 27, 2024
View reviewed changes
boards.txt
codecell.serial.disableDTR=false
codecell.serial.disableRTS=false

codecell.build.tarch=riscv32
codecell.build.target=esp
codecell.build.mcu=esp32c3
codecell.build.core=esp32
codecell.build.variant=codecell
codecell.build.variant=esp32c3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you positive of this change?

me-no-dev
me-no-dev reviewed Aug 27, 2024
View reviewed changes
me-no-dev
me-no-dev reviewed Aug 27, 2024
View reviewed changes
boards.txt
codecell.build.board=ESP32C3_DEV
codecell.build.bootloader_addr=0x0
codecell.build.cdc_on_boot=1

codecell.build.cdc_on_boot=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the board use USB to UART chip, or is it connected to the chip's USB pins?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is connected to the chip's USB pins

@me-no-dev
Copy link
Member

Please add conscious PR Title and Description

@microbotsio microbotsio reopened this Aug 30, 2024
@VojtechBartoska
Copy link
Contributor

any updates on this @microbotsio? Thanks!

@microbotsio microbotsio closed this Sep 2, 2024
@mightChamp mightChamp mentioned this pull request Oct 10, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

@P-R-O-C-H-Y P-R-O-C-H-Y Awaiting requested review from P-R-O-C-H-Y

Assignees
No one assigned
Labels
Resolution: Awaiting response Waiting for response of author Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@microbotsio @P-R-O-C-H-Y @me-no-dev @VojtechBartoska @lucasssvaz