Skip to content

Complete an IP address with 0s #10183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Complete an IP address with 0s #10183

wants to merge 1 commit into from

Conversation

rowingdude
Copy link
Contributor

The general idea was to take any partial IP address such as 192. and complete it with 0s, so 192. becomes 192.0.0.0 and so on up to a full address.

I created a second function, parseIPv4Part to check the validity of each section of the IP address we're assessing, it simply checks the value and returns a true or false, we complete on false.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "This is in response to a 'to-do' in the codebase, the idea is to complete an IP address with 0s.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello rowingdude, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 27fb6ea

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 56 files   56 suites   5m 11s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
135 runs  135 ✅ 0 💤 0 ❌

Results for commit 27fb6ea.

@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +640.00⚠️ +0.01000.000.00
ESP32S20⚠️ +600.00⚠️ +0.01000.000.00
ESP32C30⚠️ +360.00⚠️ +0.01000.000.00
ESP32C60⚠️ +360.00⚠️ +0.01000.000.00
ESP32H20⚠️ +360.00⚠️ +0.01000.000.00
ESP320⚠️ +720.00⚠️ +0.01000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA⚠️ +560⚠️ +400⚠️ +360⚠️ +360--⚠️ +680
AsyncUDP/examples/AsyncUDPClient00000000--00
AsyncUDP/examples/AsyncUDPMulticastServer00000000--00
AsyncUDP/examples/AsyncUDPServer00000000--00
BLE/examples/BLE5_extended_scan00--000000--
BLE/examples/BLE5_multi_advertising00--000000--
BLE/examples/BLE5_periodic_advertising00--000000--
BLE/examples/BLE5_periodic_sync00--000000--
BLE/examples/Beacon_Scanner00--00000000
BLE/examples/Client00--00000000
BLE/examples/EddystoneTLM_Beacon00--0000--00
BLE/examples/EddystoneURL_Beacon00--0000--00
BLE/examples/Notify00--00000000
BLE/examples/Scan00--00000000
BLE/examples/Server00--00000000
BLE/examples/Server_multiconnect00--00000000
BLE/examples/UART00--00000000
BLE/examples/Write00--00000000
BLE/examples/iBeacon00--00000000
DNSServer/examples/CaptivePortal⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
EEPROM/examples/eeprom_class000000000000
EEPROM/examples/eeprom_extra000000000000
EEPROM/examples/eeprom_write000000000000
ESP32/examples/AnalogOut/LEDCFade000000000000
ESP32/examples/AnalogOut/LEDCSingleChannel000000000000
ESP32/examples/AnalogOut/LEDCSoftwareFade000000000000
ESP32/examples/AnalogOut/SigmaDelta000000000000
ESP32/examples/AnalogOut/ledcFrequency000000000000
ESP32/examples/AnalogOut/ledcWrite_RGB000000000000
ESP32/examples/AnalogRead000000000000
ESP32/examples/AnalogReadContinuous000000000000
ESP32/examples/ArduinoStackSize000000000000
ESP32/examples/CI/CIBoardsTest000000000000
ESP32/examples/Camera/CameraWebServer0000------00
ESP32/examples/ChipID/GetChipID000000000000
ESP32/examples/DeepSleep/ExternalWakeUp0000------00
ESP32/examples/DeepSleep/TimerWakeUp00000000--00
ESP32/examples/DeepSleep/TouchWakeUp0000------00
ESP32/examples/FreeRTOS/BasicMultiThreading000000000000
ESP32/examples/FreeRTOS/Mutex000000000000
ESP32/examples/FreeRTOS/Queue000000000000
ESP32/examples/FreeRTOS/Semaphore000000000000
ESP32/examples/GPIO/BlinkRGB000000000000
ESP32/examples/GPIO/FunctionalInterrupt000000000000
ESP32/examples/GPIO/FunctionalInterruptStruct000000000000
ESP32/examples/GPIO/GPIOInterrupt000000000000
ESP32/examples/HWCDC_Events00--000000--
ESP32/examples/MacAddress/GetMacAddress000000000000
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible000000000000
ESP32/examples/RMT/RMTCallback000000000000
ESP32/examples/RMT/RMTLoopback000000000000
ESP32/examples/RMT/RMTReadXJT000000000000
ESP32/examples/RMT/RMTWriteNeoPixel000000000000
ESP32/examples/RMT/RMT_CPUFreq_Test000000000000
ESP32/examples/RMT/RMT_EndOfTransmissionState000000000000
ESP32/examples/RMT/RMT_LED_Blink000000000000
ESP32/examples/ResetReason/ResetReason000000000000
ESP32/examples/ResetReason/ResetReason2000000000000
ESP32/examples/Serial/BaudRateDetect_Demo000000000000
ESP32/examples/Serial/OnReceiveError_BREAK_Demo000000000000
ESP32/examples/Serial/OnReceive_Demo000000000000
ESP32/examples/Serial/RS485_Echo_Demo000000000000
ESP32/examples/Serial/RxFIFOFull_Demo000000000000
ESP32/examples/Serial/RxTimeout_Demo000000000000
ESP32/examples/Serial/Serial_All_CPU_Freqs000000000000
ESP32/examples/Serial/Serial_STD_Func_OnReceive000000000000
ESP32/examples/Serial/onReceiveExample000000000000
ESP32/examples/TWAI/TWAIreceive000000000000
ESP32/examples/TWAI/TWAItransmit000000000000
ESP32/examples/Template/ExampleTemplate000000000000
ESP32/examples/Time/SimpleTime00000000--00
ESP32/examples/Timer/RepeatTimer000000000000
ESP32/examples/Timer/WatchdogTimer000000000000
ESP32/examples/Touch/TouchButtonV20000--------
ESP32/examples/Touch/TouchInterrupt0000------00
ESP32/examples/Touch/TouchRead0000------00
ESP32/examples/Utilities/HEXBuilder000000000000
ESP32/examples/Utilities/MD5Builder000000000000
ESP32/examples/Utilities/SHA1Builder000000000000
ESP_I2S/examples/ES8388_loopback000000000000
ESP_I2S/examples/Record_to_WAV00--------00
ESP_I2S/examples/Simple_tone000000000000
ESP_NOW/examples/ESP_NOW_Broadcast_Master00000000--00
ESP_NOW/examples/ESP_NOW_Broadcast_Slave00000000--00
ESP_NOW/examples/ESP_NOW_Network00000000--00
ESP_NOW/examples/ESP_NOW_Serial00000000--00
ESP_SR/examples/Basic00----------
ESPmDNS/examples/mDNS-SD_Extended00000000--00
ESPmDNS/examples/mDNS_Web_Server⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
Ethernet/examples/ETH_W5500_Arduino_SPI⚠️ +440⚠️ +440⚠️ +360⚠️ +360⚠️ +360⚠️ +560
Ethernet/examples/ETH_W5500_IDF_SPI⚠️ +440⚠️ +520⚠️ +360⚠️ +360⚠️ +360⚠️ +520
Ethernet/examples/ETH_WIFI_BRIDGE00000000--00
FFat/examples/FFat_Test000000000000
FFat/examples/FFat_time00000000--00
HTTPClient/examples/Authorization⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
HTTPClient/examples/BasicHttpClient⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
HTTPClient/examples/BasicHttpsClient⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
HTTPClient/examples/HTTPClientEnterprise⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
HTTPClient/examples/ReuseConnection⚠️ +520⚠️ +560⚠️ +360⚠️ +360--⚠️ +680
HTTPClient/examples/StreamHttpClient⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
HTTPUpdate/examples/httpUpdate⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +720
HTTPUpdate/examples/httpUpdateSPIFFS⚠️ +480⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
HTTPUpdate/examples/httpUpdateSecure⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
HTTPUpdateServer/examples/WebUpdater⚠️ +560⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
Insights/examples/DiagnosticsSmokeTest000000----00
Insights/examples/MinimalDiagnostics000000----00
LittleFS/examples/LITTLEFS_test000000000000
LittleFS/examples/LITTLEFS_time00000000--00
NetBIOS/examples/ESP_NBNST00000000--00
NetworkClientSecure/examples/WiFiClientInsecure⚠️ +640⚠️ +600⚠️ +360⚠️ +360--⚠️ +640
NetworkClientSecure/examples/WiFiClientPSK⚠️ +480⚠️ +560⚠️ +360⚠️ +360--⚠️ +640
NetworkClientSecure/examples/WiFiClientSecure⚠️ +480⚠️ +560⚠️ +360⚠️ +360--⚠️ +640
NetworkClientSecure/examples/WiFiClientSecureEnterprise⚠️ +560⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade⚠️ +520⚠️ +600⚠️ +360⚠️ +360--⚠️ +640
NetworkClientSecure/examples/WiFiClientShowPeerCredentials⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
PPP/examples/PPP_Basic⚠️ +440⚠️ +440⚠️ +360⚠️ +360⚠️ +360⚠️ +560
PPP/examples/PPP_WIFI_BRIDGE00000000--00
Preferences/examples/Prefs2Struct000000000000
Preferences/examples/StartCounter000000000000
RainMaker/examples/RMakerCustom00000000--00
RainMaker/examples/RMakerCustomAirCooler00000000--00
RainMaker/examples/RMakerSonoffDualR300000000--00
RainMaker/examples/RMakerSwitch00000000--00
SD/examples/SD_Test000000000000
SD/examples/SD_time00000000--00
SD_MMC/examples/SD2USBMSC00----------
SD_MMC/examples/SDMMC_Test00--------00
SD_MMC/examples/SDMMC_time00--------00
SPI/examples/SPI_Multiple_Buses0000------00
SPIFFS/examples/SPIFFS_Test000000000000
SPIFFS/examples/SPIFFS_time00000000--00
SimpleBLE/examples/SimpleBleDevice00----000000
TFLiteMicro/examples/hello_world000000000000
Ticker/examples/Blinker000000000000
Ticker/examples/TickerBasic000000000000
Ticker/examples/TickerParameter000000000000
USB/examples/CompositeDevice0000--------
USB/examples/ConsumerControl0000--------
USB/examples/CustomHIDDevice0000--------
USB/examples/FirmwareMSC0000--------
USB/examples/Gamepad0000--------
USB/examples/HIDVendor0000--------
USB/examples/Keyboard/KeyboardLogout0000--------
USB/examples/Keyboard/KeyboardMessage0000--------
USB/examples/Keyboard/KeyboardReprogram0000--------
USB/examples/Keyboard/KeyboardSerial0000--------
USB/examples/KeyboardAndMouseControl0000--------
USB/examples/MIDI/MidiController0000--------
USB/examples/MIDI/MidiInterface0000--------
USB/examples/MIDI/MidiMusicBox0000--------
USB/examples/MIDI/ReceiveMidi0000--------
USB/examples/Mouse/ButtonMouseControl0000--------
USB/examples/SystemControl0000--------
USB/examples/USBMSC0000--------
USB/examples/USBSerial0000--------
USB/examples/USBVendor0000--------
Update/examples/AWS_S3_OTA_Update⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
Update/examples/HTTPS_OTA_Update00000000--00
Update/examples/HTTP_Client_AES_OTA_Update⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
Update/examples/HTTP_Server_AES_OTA_Update⚠️ +520⚠️ +480⚠️ +360⚠️ +360--⚠️ +640
Update/examples/OTAWebUpdater⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
Update/examples/SD_Update000000000000
WebServer/examples/AdvancedWebServer⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WebServer/examples/FSBrowser⚠️ +520⚠️ +560⚠️ +360⚠️ +360--⚠️ +640
WebServer/examples/Filters⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +680
WebServer/examples/HelloServer⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WebServer/examples/HttpAdvancedAuth⚠️ +520⚠️ +440⚠️ +360⚠️ +360--⚠️ +680
WebServer/examples/HttpAuthCallback⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +720
WebServer/examples/HttpAuthCallbackInline⚠️ +520⚠️ +440⚠️ +360⚠️ +360--⚠️ +680
WebServer/examples/HttpBasicAuth⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +680
WebServer/examples/HttpBasicAuthSHA1⚠️ +480⚠️ +520⚠️ +360⚠️ +360--⚠️ +720
WebServer/examples/HttpBasicAuthSHA1orBearerToken⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +720
WebServer/examples/MultiHomedServers⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +680
WebServer/examples/PathArgServer⚠️ +600⚠️ +480⚠️ +360⚠️ +360--⚠️ +640
WebServer/examples/SDWebServer⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +720
WebServer/examples/SimpleAuthentification⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WebServer/examples/UploadHugeFile⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WebServer/examples/WebServer⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WebServer/examples/WebUpdate⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +680
WiFi/examples/FTM/FTM_Initiator00000000--00
WiFi/examples/FTM/FTM_Responder00000000--00
WiFi/examples/SimpleWiFiServer⚠️ +520⚠️ +560⚠️ +360⚠️ +360--⚠️ +720
WiFi/examples/WPS00000000--00
WiFi/examples/WiFiAccessPoint⚠️ +560⚠️ +520⚠️ +360⚠️ +360--⚠️ +680
WiFi/examples/WiFiBlueToothSwitch00--0000--00
WiFi/examples/WiFiClient⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WiFi/examples/WiFiClientBasic⚠️ +560⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WiFi/examples/WiFiClientConnect00000000--00
WiFi/examples/WiFiClientEnterprise⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WiFi/examples/WiFiClientEvents00000000--00
WiFi/examples/WiFiClientStaticIP⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WiFi/examples/WiFiExtender00000000--00
WiFi/examples/WiFiIPv6⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +680
WiFi/examples/WiFiMulti00000000--00
WiFi/examples/WiFiMultiAdvanced⚠️ +520⚠️ +520⚠️ +360⚠️ +360--⚠️ +560
WiFi/examples/WiFiScan00000000--00
WiFi/examples/WiFiScanAsync00000000--00
WiFi/examples/WiFiScanDualAntenna00000000--00
WiFi/examples/WiFiScanTime00000000--00
WiFi/examples/WiFiSmartConfig00000000--00
WiFi/examples/WiFiTelnetToSerial⚠️ +560⚠️ +520⚠️ +360⚠️ +360--⚠️ +640
WiFi/examples/WiFiUDPClient00000000--⚠️ +40
WiFiProv/examples/WiFiProv00000000--00
Wire/examples/WireMaster000000000000
Wire/examples/WireScan000000000000
Wire/examples/WireSlave000000000000
OpenThread/examples/COAP/coap_lamp------0000--
OpenThread/examples/COAP/coap_switch------0000--
OpenThread/examples/SimpleCLI------0000--
OpenThread/examples/SimpleNode------0000--
OpenThread/examples/SimpleThreadNetwork/LeaderNode------0000--
OpenThread/examples/SimpleThreadNetwork/RouterNode------0000--
OpenThread/examples/ThreadScan------0000--
OpenThread/examples/onReceive------0000--
BluetoothSerial/examples/DiscoverConnect----------00
BluetoothSerial/examples/GetLocalMAC----------00
BluetoothSerial/examples/SerialToSerialBT----------00
BluetoothSerial/examples/SerialToSerialBTM----------00
BluetoothSerial/examples/SerialToSerialBT_Legacy----------00
BluetoothSerial/examples/SerialToSerialBT_SSP----------00
BluetoothSerial/examples/bt_classic_device_discovery----------00
BluetoothSerial/examples/bt_remove_paired_devices----------00
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code----------00
ESP32/examples/Touch/TouchButton----------00
Ethernet/examples/ETH_LAN8720----------⚠️ +560
Ethernet/examples/ETH_TLK110----------⚠️ +560

@rowingdude rowingdude changed the title This is in response to a 'to-do' in the codebase, the idea is to complete an IP address with 0s. Complete an IP address with 0s Aug 16, 2024
@lucasssvaz lucasssvaz requested a review from me-no-dev August 16, 2024 23:14
@Jason2866
Copy link
Collaborator

Why at all? Heavy code changes in a code part which is mandatory and not trivial.
Don't fix ain't broke. No benefit and code size increases.

@rowingdude
Copy link
Contributor Author

rowingdude commented Aug 17, 2024 via email

@me-no-dev
Copy link
Member

This ToDo came from Arduino themselves. I do not think we need it and if it's at all necessary ever, it should be implemented upstream: https://github.com/arduino/ArduinoCore-API/blob/master/api/IPAddress.cpp#L133

@rowingdude rowingdude closed this Aug 19, 2024
@rowingdude rowingdude deleted the rowingdude_ip_address_formats_todo branch August 19, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rowingdude @Jason2866 @me-no-dev