Skip to content

Additional UART_DATA check and pass bits back to callBack #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Additional UART_DATA check and pass bits back to callBack #10180

wants to merge 2 commits into from

Conversation

rowingdude
Copy link
Contributor

The proposed change should ensure that the callback is only triggered when appropriate conditions are met and that it passes the number of available bytes to the callback.

…gered when appropriate conditions are met, and passes the number of available bytes to the callback.
Copy link
Contributor

github-actions bot commented Aug 16, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "I propose to make this modification so that the callback is only triggered when appropriate conditions are met, and passes the number of available bytes to the callback.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty
  • the commit message "to PR":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello rowingdude, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5850b59

Copy link
Contributor

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 5850b59.

@Jason2866
Copy link
Collaborator

Which use case does generate an issue needing this proposed change?
Do not change file formatting in a PR

@rowingdude
Copy link
Contributor Author

This is a quality of code improvement. I did not mean to include my spaced out file where I was just trying to read better.

@lucasssvaz lucasssvaz requested a review from SuGlider August 16, 2024 23:17
@me-no-dev
Copy link
Member

your quality code improvement breaks compilation

@rowingdude rowingdude closed this Aug 19, 2024
@rowingdude rowingdude deleted the issue_10166 branch August 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants