Skip to content

fix components compile issues #10173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Jason2866
Copy link
Collaborator

Description of Change

Fix compile issues when Arduino is used as a component of IDF and files in managed components are changed

Tests scenarios

Compile fail of example idf_component_examples/hello_world

Related links

fix for #10167

@me-no-dev maybe there is a better fix for

Copy link
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix components compile issues":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Jason2866, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6906e61

@lucasssvaz lucasssvaz requested a review from me-no-dev August 15, 2024 17:13
@me-no-dev
Copy link
Member

can you try building the libs with this change and this removed?

@Jason2866
Copy link
Collaborator Author

Yep, had this already in mind that this should be a solution for the issue.
Will test.

@Jason2866
Copy link
Collaborator Author

@me-no-dev No, does not solve the issue in Arduino Lib Builder. Still fails.

@me-no-dev
Copy link
Member

ok then lets close this and add the fix to the lib builder
add export IDF_COMPONENT_OVERWRITE_MANAGED_COMPONENTS=1 to the beginning of build.sh

@me-no-dev
Copy link
Member

after all this is not Arduino's fault and does not need to be fixed here.

@me-no-dev me-no-dev closed this Aug 15, 2024
@Jason2866 Jason2866 deleted the patch-4 branch August 15, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants