esp32-hal-uart.c:153:9: warning: 'return' with no value, in function returning non-void

[deltaford]

Board

ESP32-S2

Device Description

ESP32-S2 Mini

Hardware Configuration

No

Version

v2.0.13

IDE Name

Arduino IDE 2.2.1

Operating System

Windows 10

Flash frequency

N/A

PSRAM enabled

yes

Upload speed

N/A

Description

Compile warning on 2.0.13 due to missing return value. Seem related to #8629

Sketch

N/A

Debug Message

_C:\Users\Stefan\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.13\cores\esp32\esp32-hal-uart.c: In function 'uartSetPins':
C:\Users\Stefan\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.13\cores\esp32\esp32-hal-uart.c:153:9: warning: 'return' with no value, in function returning non-void
         return;
         ^~~~~~
C:\Users\Stefan\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.13\cores\esp32\esp32-hal-uart.c:149:6: note: declared here
 bool uartSetPins(uint8_t uart_num, int8_t rxPin, int8_t txPin, int8_t ctsPin, int8_t rtsPin)_

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[SuGlider]

It doesn't prevent to build the firmware, but prints a warning message.
With this fix, the warning message won't be displayed anymore.

This issue doesn't affect the uartSetPins() function because it only happens in the case that the HAL level is used with a UART number higher than the limit, which is very improbable.

@me-no-dev - I see no need for a new release.

[SuGlider]

@me-no-dev / @P-R-O-C-H-Y
I was wondering if we need to increase the warning-error check setting in CI.
These messages should be picked up in the CI.

[mikrocoder]

This should definitely be rectified. Basically, this is not a warning but a serious error.

[lbernstone]

It has been fixed in master, and will be released soonish. If you want a fix today, you can patch in the pull request above (or just edit the file).

[SuGlider]

The PR #8644 fixed this issue (just a warning message).
It is already in the release/v2.x branch and in master branch:

This is not in the 2.0.14 release package, but if the user set the 3.0.0-Alpha Core in the Arduino IDE, the fix will be there already.

Therefore, the issue can be closed.

[SuGlider]

In case we release a final Arduino Core 2.0.15 version with all the fixes from release/v2.x branch, it will be in the release package for the Arduino IDE users.