Skip to content

ESP_ARDUINO_VERSION_PATCH is still 11 should have been 12.. #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
dagnall53 opened this issue Sep 7, 2023 · 5 comments · Fixed by #8615
Closed
1 task done

ESP_ARDUINO_VERSION_PATCH is still 11 should have been 12.. #8612

dagnall53 opened this issue Sep 7, 2023 · 5 comments · Fixed by #8615
Assignees
Labels
Status: In Progress ⚠️ Issue is in progress

Comments

@dagnall53
Copy link

Board

ESP32 devboard

Device Description

Dev board

Hardware Configuration

nothing special!

Version

latest master (checkout manually)

IDE Name

2.2.1

Operating System

win10

Flash frequency

80Mhz

PSRAM enabled

no

Upload speed

115200

Description

Just updated ESP32 from arduino from 2.0.11 to 2.0.12.
Noted
Failure to update ESP_ARDUINO_VERSION_PATCH from 11 to
ESP_ARDUINO_VERSION_PATCH = 12 in esp_arduino_version.h

!!
I know probably few people use this.. but I do!!

Sketch

example: 
webserver.sendContent("<br><center>Compiled with:"+String(ESP_ARDUINO_VERSION_MAJOR)+"."+String(ESP_ARDUINO_VERSION_MINOR)+"."+String(ESP_ARDUINO_VERSION_PATCH)+ " (based on ESP-EDF:"+String(esp_get_idf_version())+")</center>");

Debug Message

Reports: 
Compiled with:2.0.11 (based on ESP-EDF:v4.4.5)

Other Steps to Reproduce

checked the source and it looks like updating was simply missed before release..

I have checked existing issues, online documentation and the Troubleshooting Guide

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.
@dagnall53 dagnall53 added the Status: Awaiting triage Issue is waiting for triage label Sep 7, 2023
@VojtechBartoska VojtechBartoska added the Status: Needs investigation We need to do some research before taking next steps on this issue label Sep 7, 2023
@VojtechBartoska
Copy link
Contributor

@me-no-dev Please help with triage, thanks!

@me-no-dev
Copy link
Member

@me-no-dev Please help with triage, thanks!

nothing we can do right now, or we will need to make a new release just for that.

@SuGlider SuGlider linked a pull request Sep 7, 2023 that will close this issue
@SuGlider
Copy link
Collaborator

SuGlider commented Sep 7, 2023

I just installed the Arduino Core 2.0.12 and I can see that:
1- esp_arduino_version.h says it is version 11 #define ESP_ARDUINO_VERSION_PATCH 11
2- platform.txt has no version tag version=
3- package.json has "version": "2.0.11"

Using branch relesase/v2x the file platform.txt has version=2.0.11

2.0.12 is already released... Not sure if it can be replaced by another ZIP file.
The JSON file in the release are pointing to 2.0.12.
The ZIP files are as mentioned above.

@SuGlider
Copy link
Collaborator

SuGlider commented Sep 7, 2023

Maybe we could just update the file in order to make it have the latest version number.

@VojtechBartoska VojtechBartoska added Status: In Progress ⚠️ Issue is in progress and removed Status: Awaiting triage Issue is waiting for triage Status: Needs investigation We need to do some research before taking next steps on this issue labels Sep 11, 2023
@SuGlider
Copy link
Collaborator

fixed in 2.0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress ⚠️ Issue is in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants