-
Notifications
You must be signed in to change notification settings - Fork 7.6k
"HTTPClient::end(void)" runs are too long #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, xiruilin's above change to library does resolve the issue for me. |
can we make a pull request for this? edit: created a request. i also had difficulties with the radio stream taking easily more than the 60 seconds(!) to return from http.end() |
thanks to @Uksa007 for pointing that out.
flush tcp buffer instead of reading it byte by byte.
flush tcp buffer instead of reading it byte by byte.
In /libraries/HTTPClient/src/HTTPClient.cpp, function "void HTTPClient::end(void)", line 231:
If the unread data is very large, it will take a long time. If changed to:
You can achieve what you want.
The text was updated successfully, but these errors were encountered: