Skip to content

= should not be in #define #6939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
hairybaboon opened this issue Jul 4, 2022 · 3 comments · Fixed by #6941
Closed
1 task done

= should not be in #define #6939

hairybaboon opened this issue Jul 4, 2022 · 3 comments · Fixed by #6941
Assignees

Comments

@hairybaboon
Copy link

Board

ESP32 Adafruit Feather V2

Device Description

ESP32 Adafruit Feather V2

Hardware Configuration

Builtin button so nothing need be connected

Version

latest master (checkout manually)

IDE Name

Arduino IDE

Operating System

Windows 10

Flash frequency

compiler fails before flash

PSRAM enabled

yes

Upload speed

compiler fails before flash

Description

#define shouldn't have an equals sign - if used as is it causes compilation errors when using BUTTON in place of pin 38.

Sketch

int button_builtin = BUTTON;
void setup() {
  pinMode(button_builtin , INPUT);  // built in switch 38
}
void loop() {
  Builtin_Status = !digitalRead(button_builtin);
}

Debug Message

dfg

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.
@hairybaboon hairybaboon added the Status: Awaiting triage Issue is waiting for triage label Jul 4, 2022
@hairybaboon
Copy link
Author

The extra fields of issue report seem to have removed the link to the line of code in question (used to a more simplistic issue reporting setup)
Below is line in question.

@SuGlider SuGlider self-assigned this Jul 4, 2022
@SuGlider SuGlider added Status: Solved and removed Status: Awaiting triage Issue is waiting for triage labels Jul 4, 2022
@SuGlider
Copy link
Collaborator

SuGlider commented Jul 4, 2022

@hairybaboon - thanks for reporting!

@me-no-dev
Copy link
Member

@ladyada PTAL :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants