Skip to content

streamFile with custom HTTP code #6899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
taqiyasyaml opened this issue Jun 23, 2022 · 0 comments · Fixed by #6995
Closed
1 task done

streamFile with custom HTTP code #6899

taqiyasyaml opened this issue Jun 23, 2022 · 0 comments · Fixed by #6995
Assignees
@SuGlider
Labels
Area: BT&Wifi BT & Wifi related issues Status: Solved Type: Feature request Feature request for Arduino ESP32

Comments

@taqiyasyaml
Copy link

taqiyasyaml commented Jun 23, 2022 •
edited
Loading

Related area

WebServer

Hardware specification

ESP32-WROOM-32 (DevKit V1)

Is your feature request related to a problem?

I'm having a problem using onNotFound function. I want to serve a template according to an existing file on SPIFFS. But only HTTP code 200 is available instead of 404.

Describe the solution you'd like

I suggest to add HTTP code parameter to the streamFile or _streamFileCore functions

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

  • I confirm I have checked existing list of Feature requests and Contribution Guide.
@taqiyasyaml taqiyasyaml added the Type: Feature request Feature request for Arduino ESP32 label Jun 23, 2022
@VojtechBartoska VojtechBartoska added the Area: BT&Wifi BT & Wifi related issues label Jun 27, 2022
r-downing added a commit to r-downing/arduino-esp32 that referenced this issue Jul 16, 2022
@r-downing
added http code param to WebServer.streamFile (espressif#6899)
9077b70
@r-downing r-downing mentioned this issue Jul 16, 2022
Merged
r-downing added a commit to r-downing/arduino-esp32 that referenced this issue Jul 17, 2022
@r-downing
added http code param to WebServer.streamFile (espressif#6899)
fb038ba
r-downing added a commit to r-downing/arduino-esp32 that referenced this issue Jul 17, 2022
@r-downing
added http code param to WebServer.streamFile (espressif#6899)
90bb748
@SuGlider SuGlider added the Status: In Progress ⚠️ Issue is in progress label Jul 20, 2022
@SuGlider SuGlider self-assigned this Jul 20, 2022
SuGlider pushed a commit that referenced this issue Jul 26, 2022
@r-downing
added http code param to WebServer.streamFile (#6899) (#6995)
fef932c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuGlider SuGlider

Labels
Area: BT&Wifi BT & Wifi related issues Status: Solved Type: Feature request Feature request for Arduino ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added http code param to WebServer.streamFile (#6899) r-downing/arduino-esp32
3 participants
@taqiyasyaml @SuGlider @VojtechBartoska