all methods in the class BLEAdvertising are void and do not return any error codes

[pabloandresm]

There is not a single methond in the class BLEAdvertising located at BLEAdvertising.h/.cpp that returns any error code.

For example...BLEAdvertising::start().....that calls the syscall esp_ble_gap_start_advertising(), which returns an error, it is just ignored, and the BLEAdvertising::start() returns void.

Is there any logical explanation for this? I don't see any extra complication in the code by just returning the result of esp_ble_gap_start_advertising().

And the same thing goes for all the methods of this class.

[VojtechBartoska]

Hello, can you please retest this on v2.0.3-rc1?

[VojtechBartoska]

Hi,

I'm closing the issue due to no response.

If needed you can reopen it.

Thanks for your contribution & understanding!

[pabloandresm]

Hello, can you please retest this on v2.0.3-rc1?

Hi there,

Sorry I do not understand your request. The code did not change. The bug is still there.
Not one method of BLEAdvertising returns any error code.
I mentioned the example of ::start() that is void type. It could return the error code of esp_ble_gap_start_advertising().

Same thing for all other methods. All of void type.

[VojtechBartoska]

I see, reopening.

[FidelSch]

Hello
I would like to contribute, as this seems like a fairly simple fix. Could this be assigned to me?
As this is my first contribution, any guidelines are welcome.
Thanks in advance!

[Parsaabasi]

Hello @FidelSch
Are you still interested in the fix?
HERE is the guideline for the contributors. Please go study it and suggest your changes

Thanks.

[pabloandresm]

Hello,
I would like to implement the fix. I was the one that reported it.

[FidelSch]

I have already implemented my version for this fix, however as per @pabloandresm 's wishes I will not be opening a pull request for now. Best of luck!

[Parsaabasi]

Hi @pabloandresm
Do you have any updates on this issue?

[Jason2866]

closing since no feedback