Rollback with Arduino as ESP-IDF Component

[GKFernandes]

Hello everyone,

I ran into the same issue as stated in: #3318 and also in #3749

I think this issue about the weakly defined verify0ta() should be fixed and made in such a way that the user can perform the verification later in the code instead of inside the initArduino() function.

[me-no-dev]

How about we add a new weak function bool verifyRollbackLater() to allow you to skip verification in initArduino and do it yourself later?

[GKFernandes]

Hello @me-no-dev , I think this could be a solution, but can the function verifyOta() just be removed?

What do you think @atanisoft @marcovannoord?

[marcovannoord]

Yeah that would be a perfect solution i think, and it would just skip the verifyOTA() function.
In that case, if users want to use the verifyOTA to immediately verify rollback, then they can still use that function if they override the weak function.

[me-no-dev]

if you overwrite verifyRollbackLater, then verifyOTA will not be called at all. This whole block will not execute: https://github.com/espressif/arduino-esp32/blob/master/cores/esp32/esp32-hal-misc.c#L215-L226

[marcovannoord]

Yeah i think that's the perfect solution. That way, users can add this feature, while keeping legacy things intact.

[me-no-dev]

Done :)

[zekageri]

Any example for this?