Skip to content

warnings from Eth #5794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lbernstone opened this issue Oct 22, 2021 · 1 comment · Fixed by #5795
Closed

warnings from Eth #5794

lbernstone opened this issue Oct 22, 2021 · 1 comment · Fixed by #5795
Assignees
Milestone

Comments

@lbernstone
Copy link
Contributor

Hardware:

Board: ESP32-C3 devkit
Core Installation version: master 22/10/2021
IDE name: Arduino IDE
Computer OS: Ubuntu

Description:

Warnings from Ethernet components in WiFi.
This does not prevent compilation. I don't know if it prevents Eth from working, and don't have the stuff to test. Just wanted to get eyes on this before v2.0.1 goes out the door.

Sketch: (leave the backquotes for code formatting)

#include <Arduino.h>
#include <WiFi.h>

void setup() {
}

void loop() {
}

Debug Messages:

/home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/ETH.cpp: In member function 'bool ETHClass::begin(uint8_t, int, int, int, eth_phy_type_t, eth_clock_mode_t)':
/home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/ETH.cpp:240:46: warning: 'esp_err_t esp_eth_set_default_handlers(void*)' is deprecated [-Wdeprecated-declarations]
     if(esp_eth_set_default_handlers(eth_netif) != ESP_OK){
                                              ^
In file included from /home/larryb/Arduino/hardware/espressif/esp32/tools/sdk/esp32c3/include/esp_netif/include/esp_netif.h:26,
                 from /home/larryb/Arduino/hardware/espressif/esp32/tools/sdk/esp32c3/include/esp_event/include/esp_event_legacy.h:22,
                 from /home/larryb/Arduino/hardware/espressif/esp32/tools/sdk/esp32c3/include/esp_event/include/esp_event.h:28,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/WiFiGeneric.h:27,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/WiFiSTA.h:28,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/WiFi.h:32,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/ETH.h:24,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/ETH.cpp:21:
/home/larryb/Arduino/hardware/espressif/esp32/tools/sdk/esp32c3/include/esp_eth/include/esp_eth_netif_glue.h:59:11: note: declared here
 esp_err_t esp_eth_set_default_handlers(void *esp_netif)  __attribute__ ((deprecated));
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/ETH.cpp:240:46: warning: 'esp_err_t esp_eth_set_default_handlers(void*)' is deprecated [-Wdeprecated-declarations]
     if(esp_eth_set_default_handlers(eth_netif) != ESP_OK){
                                              ^
In file included from /home/larryb/Arduino/hardware/espressif/esp32/tools/sdk/esp32c3/include/esp_netif/include/esp_netif.h:26,
                 from /home/larryb/Arduino/hardware/espressif/esp32/tools/sdk/esp32c3/include/esp_event/include/esp_event_legacy.h:22,
                 from /home/larryb/Arduino/hardware/espressif/esp32/tools/sdk/esp32c3/include/esp_event/include/esp_event.h:28,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/WiFiGeneric.h:27,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/WiFiSTA.h:28,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/WiFi.h:32,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/ETH.h:24,
                 from /home/larryb/Arduino/hardware/espressif/esp32/libraries/WiFi/src/ETH.cpp:21:
/home/larryb/Arduino/hardware/espressif/esp32/tools/sdk/esp32c3/include/esp_eth/include/esp_eth_netif_glue.h:59:11: note: declared here
 esp_err_t esp_eth_set_default_handlers(void *esp_netif)  __attribute__ ((deprecated));
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
@SuGlider
Copy link
Collaborator

SuGlider commented Oct 22, 2021

Thanks @lbernstone
It won't prevent ETH from working.
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/network/esp_eth.html#_CPPv428esp_eth_set_default_handlersPv

It just needs to be removed from ETH.cpp. It's not needed in latest IDF 4.4 anymore.
I'll get it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants