This should return a size_t not a uint8_t. #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

felixcollins opened this issue Sep 20, 2021 · 3 comments

Contributor

felixcollins commented Sep 20, 2021

arduino-esp32/libraries/BLE/src/BLECharacteristic.h

Line 65 in 078671d

uint8_t getLength();

This should return a size_t not a uint8_t. Returning a uint8_t limits the MTU that can be used.

Contributor Author

felixcollins commented Sep 20, 2021

Contributor Author

felixcollins commented Sep 20, 2021

Work around is to call getValue()...
pCharacteristic->getValue().length()

Contributor Author

felixcollins commented Sep 21, 2021

PR accepted...

felixcollins closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment