Skip to content

SSP Functionality Incomplete #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardclli opened this issue Dec 11, 2020 · 3 comments · Fixed by #4634
Closed

SSP Functionality Incomplete #4622

richardclli opened this issue Dec 11, 2020 · 3 comments · Fixed by #4634

Comments

@richardclli
Copy link
Contributor

I have tried to make use of SSP and setup ESP32 device as slave to accept binding request from smart phones, PCs, etc. However I figure out that the SSP implementation is incomplete. Normally the binding process involves the Smart Phone initiate a binding request with a key code. User can verify the code in the ESP32 device screen, and select the desire action (either accept or reject) in the ESP32 device.

However, just make use of the BluetoothSerial API cannot make the job done. The API seems missing some callbacks mechanism for the binding process.

I need to copy and modify the BluetoothSerial source code to make this works, and I think I can contribute my work to the source as a pull request. So, if I do this, is there anybody who will review the code and merge it?

@richardclli richardclli changed the title SSP Functionality imcomplete SSP Functionality Incomplete Dec 11, 2020
@me-no-dev
Copy link
Member

Yup :) please make the pull request :)

@richardclli
Copy link
Contributor Author

One thing in the source code that I am not sure, but I changed it anyway. This is it needs to verify if it is master mode before registering the gap callback. Now I change the checking so that the gap callback will present either in master and slave mode and I need some events in the gap callback to be handled for SSP authentication.

@richardclli
Copy link
Contributor Author

I have created the pull request, please review the code, thanks.

me-no-dev pushed a commit that referenced this issue Jan 11, 2021
Added authentication callbacks and example, resolves #4622.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants