Skip to content

RMT SetCarrier duty cycle fix #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarkLogiCom opened this issue Jan 14, 2019 · 1 comment
Closed

RMT SetCarrier duty cycle fix #2316

MarkLogiCom opened this issue Jan 14, 2019 · 1 comment

Comments

@MarkLogiCom
Copy link

Board: ESP32 Dev Module
Core Installation/update date: 9 Jan 2019
IDE name: Platform.io
Flash Frequency: 40Mhz?
PSRAM enabled: no
Upload Speed: 115200
Computer OS: Windows 10

I had issues trying to set the duty cycle of the RMT carrier, looks like a copy and paste bug in the Arduino framework.
"\arduino-esp32\cores\esp32\esp32-hal-rmt.c"

bool rmtSetCarrier(rmt_obj_t* rmt, bool carrier_en, bool carrier_level, uint32_t low, uint32_t high)
{
:
RMT.carrier_duty_ch[channel].low = low;
RMT.carrier_duty_ch[channel].low = high;
:
}
The second .low should be .high - then it works fine.
Thanks for providing the RMT module, saved me a heap of time.
Mark

@me-no-dev
Copy link
Member

Hey :) thanks for finding this :) fixed in Master!

dash0820 added a commit to dash0820/arduino-esp32-stripped that referenced this issue Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants