Skip to content

analogReadResolution should be implemented #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cbxbiker61 opened this issue Jan 31, 2017 · 2 comments
Closed

analogReadResolution should be implemented #161

cbxbiker61 opened this issue Jan 31, 2017 · 2 comments
Labels
Type: Feature request Feature request for Arduino ESP32

Comments

@cbxbiker61
Copy link

sam/samd/arc32 architectures use analogReadResolution to set the analogRead() bit resolution and it looks like this will be a "normal" api call.

I see analogSetWidth in esp32-hal-adc.h. It would be extremely easy to put a compatible analogReadResolution in that calls analogSetWidth.

Something to keep in mind is that analogReadResolution can be set up to 16 bits. If the bit resolution exceeds the ADC's actual capabilities, analogRead is expected to bit-shift the ADC's result to get a 16-bit result.
@me-no-dev
Copy link
Member

cool! Will look into it :)

@me-no-dev me-no-dev added the Type: Feature request Feature request for Arduino ESP32 label Feb 23, 2017
me-no-dev added a commit that referenced this issue Mar 3, 2017
@me-no-dev
Add Arduino SAM compatible analogReadResolution and Non-Blocking ADC api
eb46978 
connected to: #220 and
#161
@me-no-dev
Copy link
Member

implemented in the latest master :)

@mMerlin mMerlin mentioned this issue May 8, 2021
Closed
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this issue Oct 18, 2021
Merged
me-no-dev pushed a commit that referenced this issue Oct 24, 2021
@P-R-O-C-H-Y
analogRead() now return value according to value set in analogReadRes…
aabbed0 
…ulotion() (#5776)

Function analogReadResolution set how many bits will analogRead return.

Find out that this functionality was added back 2017 by @me-no-dev in #161.

Related issues:
#5163
blue-2357 pushed a commit to blue-2357/arduino-esp32 that referenced this issue Jul 17, 2024
Add Arduino SAM compatible analogReadResolution and Non-Blocking ADC api
af2ef7f 
connected to: espressif/arduino-esp32#220 and
espressif/arduino-esp32#161
brentru pushed a commit to adafruit/arduino-esp32 that referenced this issue Oct 22, 2024
@tyeth
Merge pull request espressif#161 from tyeth/update-pico-flash-params
8947491 
Update pico flash params
darkxst pushed a commit to darkxst/arduino-esp32 that referenced this issue Dec 5, 2024
@Jason2866
Support IP NAPT (espressif#161)
06899c1
dash0820 added a commit to dash0820/arduino-esp32-stripped that referenced this issue Mar 10, 2025
@dash0820
Add Arduino SAM compatible analogReadResolution and Non-Blocking ADC api
9b9b591 
connected to: espressif/arduino-esp32#220 and
espressif/arduino-esp32#161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature request Feature request for Arduino ESP32
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbxbiker61 @me-no-dev